Attachment 144245 Details for Bug 32350 – Bug 32350: Die on unrecognised column passed to testbuilder

[patch] Bug 32350: Die on unrecognised column passed to testbuilder

Bug-32350-Die-on-unrecognised-column-passed-to-tes.patch (text/plain), 1.50 KB, created by Martin Renvoize (ashimema) on 2022-11-25 11:44:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-11-25 11:44:45 UTC

Size: 1.50 KB

patch

obsolete

>From c8c92b21258939fffd226f4f20ced034f74412fc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 25 Nov 2022 08:19:09 +0000
>Subject: [PATCH] Bug 32350: Die on unrecognised column passed to testbuilder
>
>This should prevent mis-matches between tests and database fields in the
>future and reduce our chances of hitting random test failures.
>
>However, it may have a performance impact on the test suite.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/lib/TestBuilder.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index d065835ded..bac6e3818e 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -12,6 +12,7 @@ use Bytes::Random::Secure;
> use Carp qw( carp );
> use Module::Load qw( load );
> use String::Random;
>+use List::Util qw( any );
> 
> use constant {
>     SIZE_BARCODE => 20, # Not perfect but avoid to fetch the value when creating a new item
>@@ -280,6 +281,11 @@ sub _buildColumnValues {
>     my @columns = $self->schema->source($source)->columns;
>     my %unique_constraints = $self->schema->source($source)->unique_constraints();
> 
>+    for my $key ( keys %{$original_value} ) {
>+        die "value passed for unrecognised column: $key"
>+          if !( any { $key eq $_ } @columns );
>+    }
>+
>     my $build_value = 5;
>     # we try max $build_value times if there are unique constraints
>     BUILD_VALUE: while ( $build_value ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32350: 144229 | 144230 | 144233 | 144234 | 144235 | 144239 | 144245 | 144246 | 144247 | 144248 | 144276 | 144277 | 144349 | 144350