Attachment 144305 Details for Bug 32257 – Bug 32257: Label for patron attributes misaligned

[patch] Bug 32257: Label for patron attributes misaligned

Bug-32257-Label-for-patron-attributes-misaligned.patch (text/plain), 3.27 KB, created by David Nind on 2022-11-28 19:27:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-11-28 19:27:00 UTC

Size: 3.27 KB

patch

obsolete

>From c5315f05b50ed089fd9b00c9ca07dfece8ca9ac1 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 23 Nov 2022 17:12:59 +0000
>Subject: [PATCH] Bug 32257: Label for patron attributes misaligned
>
>Label has now been realigned to match the format of the fields above.
>
>Test plan:
>1) Navigate to Tools > Batch patron modification
>2) Add either card or borrower numbers to bring up the edit patrons fields
>3) "Patron attributes:" is on the far right and above the select box
>4) Apply patch and navigate to same area
>5) Observe that the Patron attributes option is aligned to match the fields above
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/tools/modborrowers.tt        | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index 0837de9c73..794cc991bc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -368,14 +368,16 @@
>                                         [% END %]
>                                         [% IF ( patron_attributes_codes ) %]
>                                             <li class="attributes">
>-                                                <label style="width:auto;">Patron attribute:
>-                                                    <select name="patron_attributes">
>-                                                        <option value=""></option>
>-                                                        [% FOREACH pac IN patron_attributes_codes %]
>-                                                            <option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option>
>-                                                        [% END %]
>-                                                    </select>
>+                                                <label style="width:auto;">
>+                                                    <span>Patron attribute:</span>
>                                                 </label>
>+                                                <select name="patron_attributes">
>+                                                    <option value=""></option>
>+                                                    [% FOREACH pac IN patron_attributes_codes %]
>+                                                        <option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option>
>+                                                    [% END %]
>+                                                </select>
>+
>                                                 <input type="checkbox" title="check to delete this field" name="disable_input" value="attr0_value" />
>                                                 <span class="patron_attributes_value"><input type"hidden" name="patron_attributes_value" /></span>
>                                                 <a href="#" class="add_attributes" title="Add an attribute"><i class="fa fa-fw fa-plus"></i> New</a>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32257: 144210 | 144305 | 144443 | 144452 | 144453 | 144489 | 144490