Attachment 144306 Details for Bug 32221 – Bug 32221: Borrowers.password should no longer be an option

[patch] Bug 32221: Borrowers.password should no longer be an option

Bug-32221-Borrowerspassword-should-no-longer-be-an.patch (text/plain), 1.59 KB, created by David Nind on 2022-11-28 19:42:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-11-28 19:42:50 UTC

Size: 1.59 KB

patch

obsolete

>From 8643d5bfcf2551666db961c991a392503c1b9527 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 28 Nov 2022 14:35:37 +0000
>Subject: [PATCH] Bug 32221: Borrowers.password should no longer be an option
>
>When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice.
>
>Test plan:
>1) Navigate to Tools > Notices and slips
>2) Either create a new notice or edit an existing notice
>3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password"
>4) Apply patch
>5) Navigate to the same menu
>6) Observe that the "borrowers.password" option is now no longer visible
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> tools/letter.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index d709b2d6e9..c00cc6de3d 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -514,6 +514,7 @@ sub get_columns_for {
>     my $rows = C4::Context->dbh->selectall_arrayref($sql, { Slice => {} });
>     for my $row (@{$rows}) {
>         next if $row->{'Field'} eq 'timestamp'; # this is really an irrelevant field and there may be other common fields that should be excluded from the list
>+        next if $row->{'Field'} eq 'password'; # passwords can no longer be shown in notices so the password field should be removed as a template option
>         push @fields, {
>             value => $table_prefix . $row->{Field},
>             text  => $table_prefix . $row->{Field},
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32221: 143974 | 144284 | 144306 | 144702