Attachment 144339 Details for Bug 32366 – Bug 32366: (bug 30460 follow-up) Add tests

[patch] Bug 32366: (bug 30460 follow-up) Add tests

Bug-32366-bug-30460-follow-up-Add-tests.patch (text/plain), 2.36 KB, created by Jonathan Druart on 2022-11-30 07:57:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-11-30 07:57:45 UTC

Size: 2.36 KB

patch

obsolete

>From c226e888c32d08d2ae3d1dbd53a11c11f1e71c8f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 30 Nov 2022 08:55:13 +0100
>Subject: [PATCH] Bug 32366: (bug 30460 follow-up) Add tests
>
>---
> .../Koha/BackgroundJobs/BatchDeleteBiblio.t   | 20 ++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t b/t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
>index 60e60ed0490..fa1a332fb44 100755
>--- a/t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
>+++ b/t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
>@@ -36,10 +36,12 @@ my $builder = t::lib::TestBuilder->new;
> 
> subtest "process() tests" => sub {
> 
>-    plan tests => 2;
>+    plan tests => 3;
> 
>     $schema->storage->txn_begin;
> 
>+    t::lib::Mocks::mock_preference('SearchEngine', 'Elasticsearch');
>+
>     my $biblio = $builder->build_sample_biblio;
>     my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->id });
>     my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->id });
>@@ -54,11 +56,18 @@ subtest "process() tests" => sub {
>         }
>     );
> 
>-    my $counter = 0;
>+    my $update_biblio_counter = 0;
> 
>     my $mock_holds_queue_job = Test::MockModule->new('Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue');
>     $mock_holds_queue_job->mock( 'enqueue', sub {
>-        $counter++;
>+        $update_biblio_counter++;
>+    });
>+
>+    my $index_biblio_counter = 0;
>+
>+    my $mock_index = Test::MockModule->new("Koha::SearchEngine::Elasticsearch::Indexer");
>+    $mock_index->mock( 'index_records', sub {
>+        $index_biblio_counter++;
>     });
> 
>     my $job = Koha::BackgroundJob::BatchDeleteBiblio->new(
>@@ -81,7 +90,8 @@ subtest "process() tests" => sub {
>         }
>     );
> 
>-    is( $counter, 1, 'Holds queue update is enqueued only once' );
>+    is( $update_biblio_counter, 1, 'Holds queue update is enqueued only once' );
>+    is( $index_biblio_counter,  1, 'Index update is enqueued only once' );
> 
>     t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
> 
>@@ -105,7 +115,7 @@ subtest "process() tests" => sub {
>         }
>     );
> 
>-    is( $counter, 1, 'Counter untouched with RealTimeHoldsQueue disabled' );
>+    is( $update_biblio_counter, 1, 'Counter untouched with RealTimeHoldsQueue disabled' );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32366: 144339 | 144346