Bugzilla – Attachment 14435 Details for
Bug 7703
Don't block bulk hold action on search results if some items can't be placed on hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7703 - Don't block bulk hold action if some items can't be placed on hold
SIGNED-OFF-Bug-7703---Dont-block-bulk-hold-action-.patch (text/plain), 2.60 KB, created by
Owen Leonard
on 2013-01-04 20:22:26 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7703 - Don't block bulk hold action if some items can't be placed on hold
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-01-04 20:22:26 UTC
Size:
2.60 KB
patch
obsolete
>From 1ef1134869fb644a724a9cbad7eda1433696af83 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 2 Jan 2013 08:21:52 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 7703 - Don't block bulk hold action if some > items can't be placed on hold >Content-Type: text/plain; charset="utf-8" > >If you select multiple titles on the search results page in order to >place a bulk hold and some of those titles have no items you get a >JavaScript alert warning you can some cannot be placed on hold. You are >blocked from completing the action until you deselect the invalid hold. > >This is unnecessary because the bulk hold process will safely refuse to >place a hold on these titles later in the process. > >This patch removes the check that prevents submitting a multi-hold if >one or more records in the multi-hold have no items. > >Test plan: >1) Apply patch >2) On the staff interface, do a search >3) On the search results, select at least one record with items and one >record with no items. >4) Click the 'Place hold' button. >5) You should be redirected to reserve/request.pl with the message >"Cannot place hold: this record has no items attached." > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Added a description of the problem and copied the test plan from the bug >report, fulfilling commit message guidelines. >--- > .../prog/en/modules/catalogue/results.tt | 10 ---------- > 1 file changed, 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 4d89a53..eb8f8f8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -4,7 +4,6 @@ > <script type="text/javascript"> > //<![CDATA[ > var MSG_NO_ITEM_SELECTED = _("Nothing is selected."); >-var MSG_NON_RESERVES_SELECTED = _("One or more selected items cannot be placed on hold."); > var q_array = new Array(); // will hold search terms, if present > [% IF ( AmazonCoverImages ) %] > // http://www.oreillynet.com/pub/a/javascript/2003/10/21/amazonhacks.html >@@ -133,19 +132,10 @@ function placeHold () { > return false; > } > var bibs = ""; >- var badBibs = false; > $(checkedItems).each(function() { > var bib = $(this).val(); >- if ($("#reserve_" + bib).size() == 0) { >- alert(MSG_NON_RESERVES_SELECTED); >- badBibs = true; >- return false; >- } > bibs += bib + "/"; > }); >- if (badBibs) { >- return false; >- } > $("#hold_form_biblios").val(bibs); > $("#hold_form").submit(); > return false; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7703
:
9613
|
14360
|
14435
|
15290
|
19114
|
19115
|
28144
|
52166
|
52167
|
52168
|
52295
|
52296
|
123575
|
123576
|
123577
|
123812
|
123813
|
123814
|
124233
|
124234
|
124235