Attachment 144352 Details for Bug 31381 – Bug 31381: Add tests

[patch] Bug 31381: Add tests

Bug-31381-Add-tests.patch (text/plain), 1.91 KB, created by Tomás Cohen Arazi (tcohen) on 2022-11-30 18:33:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-11-30 18:33:15 UTC

Size: 1.91 KB

patch

obsolete

>From 4e16ea0164270bbb330743b437385b77a71e871f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 23 Nov 2022 09:30:33 +0100
>Subject: [PATCH] Bug 31381: Add tests
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../api/v1/patrons_extended_attributes.t      | 26 ++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/patrons_extended_attributes.t b/t/db_dependent/api/v1/patrons_extended_attributes.t
>index 1766576fcb4..278631fb339 100755
>--- a/t/db_dependent/api/v1/patrons_extended_attributes.t
>+++ b/t/db_dependent/api/v1/patrons_extended_attributes.t
>@@ -34,7 +34,7 @@ t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
> 
> subtest 'list_patron_attributes() tests' => sub {
> 
>-    plan tests => 9;
>+    plan tests => 10;
> 
>     $schema->storage->txn_begin;
> 
>@@ -68,6 +68,30 @@ subtest 'list_patron_attributes() tests' => sub {
>       ->status_is( 404 )
>       ->json_is( '/error' => 'Patron not found' );
> 
>+    subtest 'nullable value' => sub {
>+        # FIXME This is not correct, we should remove the NULLABLE clause at the DBMS level
>+        # This test will need to be adjusted on bug 32331
>+        plan tests => 3;
>+
>+        my $user = $builder->build_object({class => 'Koha::Patrons'});
>+
>+        $builder->build_object(
>+            {
>+                class => 'Koha::Patron::Attributes',
>+                value => { borrowernumber => $user->id, attribute => undef }
>+            }
>+        );
>+
>+        $t->get_ok( "//$userid:$password@/api/v1/patrons/"
>+              . $user->id
>+              . '/extended_attributes' )->status_is( 200, 'SWAGGER3.2.2' )
>+          ->json_is(
>+            '' => $user->extended_attributes->to_api,
>+            'Extended attributes retrieved correctly'
>+          );
>+
>+    };
>+
>     $schema->storage->txn_rollback;
> };
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31381: 144173 | 144188 | 144196 | 144197 | 144351 | 144352