Bugzilla – Attachment 144366 Details for
Bug 32302
"ISBN" label shows when no ISBN data present when sending list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32302: Hide "ISBN" label when no ISBN data when sending list
Bug-32302-Hide-ISBN-label-when-no-ISBN-data-when-s.patch (text/plain), 1.56 KB, created by
David Cook
on 2022-11-30 22:56:49 UTC
(
hide
)
Description:
Bug 32302: Hide "ISBN" label when no ISBN data when sending list
Filename:
MIME Type:
Creator:
David Cook
Created:
2022-11-30 22:56:49 UTC
Size:
1.56 KB
patch
obsolete
>From c88d71797d52676e6054c11398267ba1e1aa03e8 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 1 Dec 2022 09:52:55 +1100 >Subject: [PATCH] Bug 32302: Hide "ISBN" label when no ISBN data when sending > list > >There is a logic mistake in the opac-sendshelf.tt template where >we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when >we should really be testing if the arrayref returned by "ISBN" is >empty or not, since that "ISBN" key always exists and contains at least >an empty arrayref. > >Test plan: >1. Apply patch and restart your Koha Starman >2. Create a public list containing records with 020 MARC fields and >records without 020 MARC fields >3. View the list in the OPAC >4. Click "Send list" and email it to yourself >5. Note that only records with 020 MARC fields with show "ISBN:" >in the email output >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt >index 168dce74be..872e188694 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt >@@ -58,7 +58,7 @@ Your list : [% shelfname | $raw %] > </span><br/> > [% END %] > >- [% IF ( BIBLIO_RESULT.ISBN ) %] >+ [% IF ( BIBLIO_RESULT.ISBN.size > 0 ) %] > <span> > ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %] > [% isbn | $raw %] >-- >2.35.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32302
:
144366
|
144368
|
144369
|
144526
|
144527