Bugzilla – Attachment 144402 Details for
Bug 28975
Holds queue lists can show holds from all libraries even with IndependentBranches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28975: Holds queue lists can show holds from all libraries even with IndependentBranches
Bug-28975-Holds-queue-lists-can-show-holds-from-al.patch (text/plain), 2.60 KB, created by
Kyle M Hall (khall)
on 2022-12-02 14:18:48 UTC
(
hide
)
Description:
Bug 28975: Holds queue lists can show holds from all libraries even with IndependentBranches
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-12-02 14:18:48 UTC
Size:
2.60 KB
patch
obsolete
>From 6ff953c5bc615c9f1794873e139c04357061ed98 Mon Sep 17 00:00:00 2001 >From: The Minh Luong <the-minh.luong@inlibro.com> >Date: Tue, 25 Jan 2022 12:20:38 -0500 >Subject: [PATCH] Bug 28975: Holds queue lists can show holds from all > libraries even with IndependentBranches > >When using IndependentBranches, usually all branches are removed from the drop-down menus. But in the Holds Queue page, there is the possibility to choose "All branches". From there, you can see holds from all libraries. > >To recreate : >1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers >2) Create a staff user with limited permissions (NOT a superlibrarian), including holds permissions. Here are mine as an example > - circulate (all) > - catalogue > - borrowers > - delete_borrowers > - edit_borrowers > - reserveforothers (all) > - reports (all) >3) Create (or make sure you already have) a patron in another branch (we'll call them patron X) >4) Place a hold for patron X on an available item from their own library >5) Run misc/cronjobs/holds/build_holds_queue.pl >6) Go to Circulation > Holds queue and make sure you can see the hold >7) Log in as your limited staff patron >8) Go to Circulation > Holds queue >9) In the drop-down menu, choose "All" and click Submit >-- Notice you see the hold of the patron from another branch under Patron >column: "A patron from library <library name>" >11) Apply the patch. >12) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index 3c43049704..ab29248b53 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -259,7 +259,9 @@ > <li> > <label for="branchlimit">Library: </label> > <select name="branchlimit" id="branchlimit"> >+ [% IF !Koha.Preference('IndependentBranches') || (Koha.Preference('IndependentBranches') && CAN_user_superlibrarian) %] > <option value="">All</option> >+ [% END %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branchlimit, only_from_group => 1 ) %] > </select> > </li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28975
:
129810
|
137133
|
137170
| 144402 |
144403