Attachment 144410 Details for Bug 32292 – Bug 32292: Add column descriptions to subscriptions table / complete items table

[patch] Bug 32292: Add column descriptions to subscriptions table / complete items table

Bug-32292-Add-column-descriptions-to-subscriptions.patch (text/plain), 6.68 KB, created by David Nind on 2022-12-03 20:18:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-12-03 20:18:10 UTC

Size: 6.68 KB

patch

obsolete

>From 9b62dbc1e6078dc078e6c9c872599a04c203dd60 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 21 Nov 2022 21:36:31 +0000
>Subject: [PATCH] Bug 32292: Add column descriptions to subscriptions table /
> complete items table
>
>* Adds proper labels to the database columns for suggestions
>* Adds missing item columns:
>  * coded_location_qualifier
>  * deleted_on
>  * exclude_form_local_holds_priority
>* Fixes spelling of item type, Uniform resource identifier
>
>To test:
>* Go to reports > Guided reports
>* Select acquisition or another module using the items
>* Make sure all entries for the tables items up with nice descriptions
>* Changes to subscriptions: verify reading the patch, these don't seem to show
>  up yet in guided reports.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/Database/Columns.pm | 87 +++++++++++++++++++++-------------------
> 1 file changed, 45 insertions(+), 42 deletions(-)
>
>diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm
>index 0fe0efc181..519a215b9b 100644
>--- a/Koha/Database/Columns.pm
>+++ b/Koha/Database/Columns.pm
>@@ -142,35 +142,38 @@ sub columns {
>             "datelastseen"         => __("Date last seen"),
>             "stack"                => __("Shelving control number"),
>             "onloan"               => __("Due date"),
>-            "cn_source"            => __("Source of classification / shelving scheme"),
>-            "cn_sort"              => __("Koha normalized classification for sorting"),
>-            "notforloan"           => __("Not for loan"),
>-            "itemlost"             => __("Lost status"),
>-            "itemlost_on"          => __("Lost on"),
>-            "withdrawn"            => __("Withdrawn status"),
>-            "withdrawn_on"         => __("Withdrawn on"),
>-            "itemcallnumber"       => __("Call number"),
>-            "issues"               => __("Total checkouts"),
>-            "renewals"             => __("Total renewals"),
>-            "reserves"             => __("Total holds"),
>-            "restricted"           => __("Use restrictions"),
>-            "itemnotes"            => __("Public note"),
>-            "itemnotes_nonpublic"  => __("Internal note"),
>-            "holdingbranch"        => __("Current library"),
>-            "timestamp"            => __("Timestamp"),
>-            "location"             => __("Shelving location"),
>-            "permanent_location"   => __("Permanent shelving location"),
>-            "ccode"                => __("Collection"),
>-            "itype"                => __("Koha itemtype"),
>-            "stocknumber"          => __("Inventory number"),
>-            "damaged"              => __("Damaged status"),
>-            "damaged_on"           => __("Damaged on"),
>-            "materials"            => __("Materials specified"),
>-            "uri"                  => __("Uniform Resource Identifier"),
>-            "more_subfields_xml"   => __("Additional subfields (XML)"),
>-            "enumchron"            => __("Serial enumeraton/chronology"),
>-            "copynumber"           => __("Copy number"),
>-            "new_status"           => __("New status"),
>+            "cn_source"    => __("Source of classification / shelving scheme"),
>+            "cn_sort"      => __("Koha normalized classification for sorting"),
>+            "notforloan"   => __("Not for loan"),
>+            "itemlost"     => __("Lost status"),
>+            "itemlost_on"  => __("Lost on"),
>+            "withdrawn"    => __("Withdrawn status"),
>+            "withdrawn_on" => __("Withdrawn on"),
>+            "itemcallnumber"           => __("Call number"),
>+            "coded_location_qualifier" => __("Coded location qualifier"),
>+            "issues"                   => __("Total checkouts"),
>+            "renewals"                 => __("Total renewals"),
>+            "reserves"                 => __("Total holds"),
>+            "restricted"               => __("Use restrictions"),
>+            "itemnotes"                => __("Public note"),
>+            "itemnotes_nonpublic"      => __("Internal note"),
>+            "holdingbranch"            => __("Current library"),
>+            "timestamp"                => __("Timestamp"),
>+            "deleted_on"               => __("Date of deletion"),
>+            "location"                 => __("Shelving location"),
>+            "permanent_location"       => __("Permanent shelving location"),
>+            "ccode"                    => __("Collection"),
>+            "itype"                    => __("Koha item type"),
>+            "stocknumber"              => __("Inventory number"),
>+            "damaged"                  => __("Damaged status"),
>+            "damaged_on"               => __("Damaged on"),
>+            "materials"                => __("Materials specified"),
>+            "uri"                      => __("Uniform resource identifier"),
>+            "more_subfields_xml"       => __("Additional subfields (XML)"),
>+            "enumchron"                => __("Serial enumeraton/chronology"),
>+            "copynumber"               => __("Copy number"),
>+            "new_status"               => __("New status"),
>+            "exclude_from_local_holds_priority" => __("Exclude from local holds priority"),
>         },
>         statistics => {
>             "datetime"       => __("Statistics date and time"),
>@@ -222,19 +225,19 @@ sub columns {
>             "location"    => __("Location"),
>             "branchcode"  => __("Library"),
>         },
>-        suggestions=> {
>-            "author"          => __("author"),
>-            "copyrightdate"   => __("copyrightdate"),
>-            "isbn"            => __("isbn"),
>-            "publishercode"   => __("publishercode"),
>-            "collectiontitle" => __("collectiontitle"),
>-            "place"           => __("place"),
>-            "quantity"        => __("quantity"),
>-            "itemtype"        => __("itemtype"),
>-            "branchcode"      => __("branchcode"),
>-            "patronreason"    => __("patronreason"),
>-            "note"            => __("note"),
>-            "title"           => __("title"),
>+        suggestions => {
>+            "author"          => __("Author"),
>+            "copyrightdate"   => __("Copyright date"),
>+            "isbn"            => __("ISBN"),
>+            "publishercode"   => __("Publisher"),
>+            "collectiontitle" => __("Collection title"),
>+            "place"           => __("Place of publication"),
>+            "quantity"        => __("Quantity"),
>+            "itemtype"        => __("Item type"),
>+            "branchcode"      => __("Library"),
>+            "patronreason"    => __("Patron reason"),
>+            "note"            => __("Note"),
>+            "title"           => __("Title"),
>         }
>     };
> }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32292: 144137 | 144138 | 144139 | 144140 | 144141 | 144410 | 144411 | 144412 | 144413 | 144414 | 145853 | 145854 | 145855 | 145856 | 145857 | 145868