Attachment 144525 Details for Bug 31160 – Bug 31160: Required fields in patron api

[patch] Bug 31160: Required fields in patron api

Bug-31160-Required-fields-in-patron-api.patch (text/plain), 1.49 KB, created by Marcel de Rooy on 2022-12-09 10:47:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-12-09 10:47:43 UTC

Size: 1.49 KB

patch

obsolete

>From 52ff71e7bce3622b025b5230cd58d9e2e64d11e2 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Thu, 24 Nov 2022 15:37:51 +0000
>Subject: [PATCH] Bug 31160: Required fields in patron api
>Content-Type: text/plain; charset=utf-8
>
>The Patron API PUT request required the fields "surname","address","city","library_id","category_id". Meanwhile the CSV import page for patrons only requires "surname","library_id","category_id". The fields for "address" and "city" have been removed from the "required" section of the api>v1>swagger>definitions>patron.yaml file to match the CSV import page.
>
>Test Plan:
>1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty body
>2) Error message should ask for 5 missing fields as listed above
>3) Apply patch
>4) Restart Apache server using "restart_all" in your ktd shell
>5) Resubmit your request
>6) Error message should now only request "surname","library_id","category_id"
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> api/v1/swagger/definitions/patron.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/api/v1/swagger/definitions/patron.yaml b/api/v1/swagger/definitions/patron.yaml
>index b5142dba06..7967722db7 100644
>--- a/api/v1/swagger/definitions/patron.yaml
>+++ b/api/v1/swagger/definitions/patron.yaml
>@@ -377,7 +377,5 @@ properties:
> additionalProperties: false
> required:
>   - surname
>-  - address
>-  - city
>   - library_id
>   - category_id
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31160: 144218 | 144308 | 144313 | 144525