Bugzilla – Attachment 144607 Details for
Bug 20596
Authority record matching rule causes staging failure when MARC record contains multiple tag values for a match point
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20596: (QA follow-up) perltidy
Bug-20596-QA-follow-up-perltidy.patch (text/plain), 2.05 KB, created by
Martin Renvoize (ashimema)
on 2022-12-15 08:19:09 UTC
(
hide
)
Description:
Bug 20596: (QA follow-up) perltidy
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-12-15 08:19:09 UTC
Size:
2.05 KB
patch
obsolete
>From 0e735f4764095197cb10760a00d99daa78432955 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 14 Dec 2022 20:31:53 -1000 >Subject: [PATCH] Bug 20596: (QA follow-up) perltidy > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > C4/AuthoritiesMarc.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 10d43422c9e..0a2a736493d 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -206,18 +206,18 @@ sub SearchAuthorities { > } #if value > } > ##Add how many queries generated >- if (defined $query && $query=~/\S+/){ >+ if ( defined $query && $query =~ /\S+/ ) { > #NOTE: This code path is used by authority search in cataloguing plugins... > #FIXME: This does not quite work the way the author probably intended. > #It creates a ($query prefix) AND (query 1) AND (query 2) structure instead of > #($query prefix) AND (query 1 AND query 2) >- $query= $and x $attr_cnt . $query . (defined $q2 ? $q2 : ''); >+ $query = $and x $attr_cnt . $query . ( defined $q2 ? $q2 : '' ); > } else { > #NOTE: This code path is used by authority search in authority home and record matching rules... > my $op_prefix = ''; > #NOTE: Without the following code, multiple queries will never be joined together > #with a Boolean operator. >- if ($attr_cnt > 1){ >+ if ( $attr_cnt > 1 ) { > #NOTE: We always need 1 less operator than we have operands, > #so long as there is more than 1 operand > my $or_cnt = $attr_cnt - 1; >@@ -225,7 +225,7 @@ sub SearchAuthorities { > $op_prefix = ' @or ' x $or_cnt; > #NOTE: This evaluates to a logical structure like (query 1) OR (query 2) OR (query 3) > } >- $query= $op_prefix . $q2; >+ $query = $op_prefix . $q2; > } > ## Adding order > #$query=' @or @attr 7=2 @attr 1=Heading 0 @or @attr 7=1 @attr 1=Heading 1'.$query if ($sortby eq "HeadingDsc"); >-- >2.39.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20596
:
74361
|
144550
|
144551
|
144561
|
144562
|
144590
|
144591
|
144598
|
144599
|
144600
|
144605
|
144606
| 144607