Attachment 144608 Details for Bug 32464 – Bug 32464: (follow-up) fix t/db_dependent/Koha/Item.t

[patch] Bug 32464: (follow-up) fix t/db_dependent/Koha/Item.t

Bug-32464-follow-up-fix-tdbdependentKohaItemt.patch (text/plain), 1.77 KB, created by Fridolin Somers on 2022-12-15 09:11:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-12-15 09:11:05 UTC

Size: 1.77 KB

patch

obsolete

>From ca61ea51566a004d7572e67c206b85e08f6f9814 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 14 Dec 2022 23:08:40 -1000
>Subject: [PATCH] Bug 32464: (follow-up) fix t/db_dependent/Koha/Item.t
>
>Remove useless unit tests with mss arg
>
>Test with :
>prove t/db_dependent/Koha/Filter/EmbedItems.t
>---
> t/db_dependent/Koha/Item.t | 20 ++------------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t
>index 21ac0bae98..8b94c9e81c 100755
>--- a/t/db_dependent/Koha/Item.t
>+++ b/t/db_dependent/Koha/Item.t
>@@ -322,7 +322,7 @@ subtest "as_marc_field() tests" => sub {
>     my @schema_columns = $schema->resultset('Item')->result_source->columns;
>     my @mapped_columns = grep { exists $mss->{'items.'.$_} } @schema_columns;
> 
>-    plan tests => 2 * (scalar @mapped_columns + 1) + 4;
>+    plan tests => scalar @mapped_columns + 5;
> 
>     $schema->storage->txn_begin;
> 
>@@ -330,23 +330,7 @@ subtest "as_marc_field() tests" => sub {
>     # Make sure it has at least one undefined attribute
>     $item->set({ replacementprice => undef })->store->discard_changes;
> 
>-    # Tests with the mss parameter
>-    my $marc_field = $item->as_marc_field({ mss => $mss });
>-
>-    is(
>-        $marc_field->tag,
>-        $itemtag,
>-        'Generated field set the right tag number'
>-    );
>-
>-    foreach my $column ( @mapped_columns ) {
>-        my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
>-        is( $marc_field->subfield($tagsubfield),
>-            $item->$column, "Value is mapped correctly for column $column" );
>-    }
>-
>-    # Tests without the mss parameter
>-    $marc_field = $item->as_marc_field();
>+    my $marc_field = $item->as_marc_field;
> 
>     is(
>         $marc_field->tag,
>-- 
>2.35.5

Actions: View | Diff | Splinter Review

Attachments on bug 32464: 144558 | 144604 | 144608 | 151542 | 151543