Attachment 144612 Details for Bug 32061 – Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

[patch] Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

Bug-32061-Remove-spans-from-page-titles-for-adding.patch (text/plain), 1.98 KB, created by Tomás Cohen Arazi (tcohen) on 2022-12-15 12:44:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-12-15 12:44:24 UTC

Size: 1.98 KB

patch

obsolete

>From 5dff3886b3117205a49badd03ca6f234e4531936 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 16 Nov 2022 22:47:35 +0000
>Subject: [PATCH] Bug 32061: Remove spans from page titles for adding/editing
> Z39.50/SRU servers
>
>In another bug we added spans to ease translations in the PROCESS
>block for server types. This PROCESS is used in several places,
>but only creates a problem when used in the title.
>
>The patch removes the spans using the remove TT filter avoiding
>having to change the PROCESS and causing a string change.
>
>To test:
>* Go to administration > Z39.50/SRU servers
>* Add a new Z39.50 and a SRU server or look at the form
>* The page title in the browser tab will show the span
>* Same for editing an existing Z39.50 or SRU server
>* Apply the patch
>* Verify the page titles are now correct
>
>Hint: you can see the full page title when hovering on the tab.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Hammat Wele <hammat@inlibro.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>index 0bd7b8a8691..4b345ee8514 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>@@ -13,10 +13,10 @@
> 
> <title>
>     [% IF op == 'edit' %]
>-        Modify [% PROCESS ServerType %] server [% server.servername | html %] &rsaquo; [% END %]
>+        Modify [% PROCESS ServerType | remove("</*span>") %] server [% server.servername | html %] &rsaquo; [% END %]
> 
>     [% IF op ==  'add' %]
>-        New [% PROCESS ServerType %] server &rsaquo; [% END %]
>+        New [% PROCESS ServerType | remove("</*span>") %] server &rsaquo; [% END %]
> 
>     Z39.50/SRU servers &rsaquo; Administration &rsaquo; Koha
> </title>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32061: 143978 | 144024 | 144041 | 144612