Attachment 144670 Details for Bug 32394 – Bug 32394: (follow-up) Add param for Koha::BackgroundJob::StageMARCForImport->enqueue

[patch] Bug 32394: (follow-up) Add param for Koha::BackgroundJob::StageMARCForImport->enqueue

Bug-32394-follow-up-Add-param-for-KohaBackgroundJo.patch (text/plain), 1.58 KB, created by Tomás Cohen Arazi (tcohen) on 2022-12-16 12:01:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-12-16 12:01:37 UTC

Size: 1.58 KB

patch

obsolete

>From 3dcdd6db788b2c23320ca24a900d37d0454dbbec Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 16 Dec 2022 09:00:45 -0300
>Subject: [PATCH] Bug 32394: (follow-up) Add param for
> Koha::BackgroundJob::StageMARCForImport->enqueue
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/BackgroundJob/StageMARCForImport.pm               | 1 +
> t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/BackgroundJob/StageMARCForImport.pm b/Koha/BackgroundJob/StageMARCForImport.pm
>index 423bc64bb57..7858eae7a0a 100644
>--- a/Koha/BackgroundJob/StageMARCForImport.pm
>+++ b/Koha/BackgroundJob/StageMARCForImport.pm
>@@ -196,6 +196,7 @@ Enqueue the new job
> sub enqueue {
>     my ( $self, $args) = @_;
> 
>+    # FIXME: no $args validation
>     $self->SUPER::enqueue({
>         job_size  => 0, # TODO Unknown for now?
>         job_args  => $args,
>diff --git a/t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t b/t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t
>index 51a23973f24..1a8e0b495f1 100755
>--- a/t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t
>+++ b/t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t
>@@ -35,7 +35,7 @@ subtest 'enqueue() tests' => sub {
> 
>     $schema->storage->txn_begin;
> 
>-    my $job_id = Koha::BackgroundJob::StageMARCForImport->new->enqueue();
>+    my $job_id = Koha::BackgroundJob::StageMARCForImport->new->enqueue({});
>     my $job    = Koha::BackgroundJobs->find($job_id)->_derived_class;
> 
>     is( $job->size,   0,            'Size is correct' );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32394: 144400 | 144444 | 144524 | 144567 | 144568 | 144585 | 144586 | 144587 | 144670 | 145964 | 145965 | 145966