Attachment 144678 Details for Bug 20473 – Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items

[patch] Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items

Bug-20473-Dont-display-Item-information-tab-when-a.patch (text/plain), 3.68 KB, created by Nick Clemens (kidclamp) on 2022-12-16 14:00:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-12-16 14:00:16 UTC

Size: 3.68 KB

patch

obsolete

>From 70aee3c0fc8fea975a595cb98c1600a1a74363e4 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 16 Dec 2022 13:12:19 +0000
>Subject: [PATCH] Bug 20473: Don't display 'Item information' tab when adding
> to basket from a file and not creating items
>
>This patch adds a conditional, and moves another up one level to remove the tab
>when it will have no content/effect
>
>To test:
>1. Stage a MARC file from Tools > Stage MARC records for import
>2. Go to Acquisitions and create a basket for a vendor
>3. Add to basket from staged file
>4. Note that the "item information" tab is present, if you click on it, not that it is not useful
>5. Cancel adding to basket
>6. Apply patch
>7. Add to basket from the staged file again
>8. Confirm there is no item information tab
>9. Confirm orders are added on 'Save'
>---
> .../prog/en/modules/acqui/addorderiso2709.tt              | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>index 6151926baf..2e82165802 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>@@ -72,7 +72,9 @@
>                         <div id="tabs" class="toptabs">
>                             <ul class="nav nav-tabs" role="tablist">
>                                 <li role="presentation" class="active"><a href="#records_to_import" aria-controls="records_to_import" role="tab" data-toggle="tab">Select to import</a></li>
>-                                <li role="presentation"><a href="#items_info" class="items_info" aria-controls="items_info" role="tab" data-toggle="tab">Item information</a></li>
>+                                [% IF items %]
>+                                    <li role="presentation"><a href="#items_info" class="items_info" aria-controls="items_info" role="tab" data-toggle="tab">Item information</a></li>
>+                                [% END %]
>                                 <li role="presentation"><a href="#accounting_details" aria-controls="accounting_details" role="tab" data-toggle="tab">Default accounting details</a></li>
>                             </ul>
> 
>@@ -368,11 +370,11 @@
>                                     </div> 
>                                 </div> 
> 
>+                                [% IF ( items ) %]
>                                 <div id="items_info" role="tabpanel" class="tab-pane">
>                                     <h2>Item information</h2>
>                                     <p>Import all the checked items in the basket with the following parameters:</p>
> 
>-                                    [% IF ( items ) %]
>                                             <fieldset class="rows" style="float:none;">
>                                                 <legend>Item</legend>
>                                                 [% IF ( NoACQframework ) %]
>@@ -422,8 +424,8 @@
>                                                     [% END #/FOREACH item %]
>                                                 </div> 
>                                             </fieldset>
>-                                    [% END # /IF items %]
>                                 </div> 
>+                                [% END # /IF items %]
> 
>                                 <div id="accounting_details" role="tabpanel" class="tab-pane">
>                                     <p>Import all the checked items in the basket with the following accounting details (used only if no information is filled for the item):</p>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 20473: 144676 | 144677 | 144678 | 144679 | 144729 | 144730 | 145824 | 145825