Bugzilla – Attachment 144886 Details for
Bug 32503
Holds awaiting pickup doesn't sort dates correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32503: (follow-up) Move data-order attributes
Bug-32503-follow-up-Move-data-order-attributes.patch (text/plain), 3.13 KB, created by
Martin Renvoize (ashimema)
on 2022-12-29 11:38:04 UTC
(
hide
)
Description:
Bug 32503: (follow-up) Move data-order attributes
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-12-29 11:38:04 UTC
Size:
3.13 KB
patch
obsolete
>From 4c14981ea195f10b5bc8324e9865e47b8cd45d56 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 29 Dec 2022 11:33:47 +0000 >Subject: [PATCH] Bug 32503: (follow-up) Move data-order attributes > >It looks like the data-order attributes were at the wrong level to me, >i.e. not part of the 'td' but instead part of the cell content. > >This patch moves those data-order attributes where possible and drops >the data-type definitions on the headers. > >However, for the cancellation case, this isn't as clear cut as we may >well display more than one cancellation request date in the same cell. >For this case I've left Katrins data-type="@data-order" trick. >--- > .../intranet-tmpl/prog/en/includes/waiting_holds.inc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index b08540f1319..8440476f68e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -5,12 +5,12 @@ > <thead> > <tr> > <th class="NoSort"><input type="checkbox" class="select_hold_all"/></th> >- <th data-type="@data-sort">Waiting since</th> >- <th data-type="@data-sort">Date hold placed</th> >+ <th>Waiting since</th> >+ <th>Date hold placed</th> > [% IF table_name == 'holdscr' %] > <th data-type="@data-sort">Date cancellation requested</th> > [% END %] >- <th data-type="@data-sort">Expiration date</th> >+ <th>Expiration date</th> > <th class="anti-the">Title</th> > <th>Patron</th> > <th>Home library</th> >@@ -26,8 +26,8 @@ > [% FOREACH reserveloo IN reserveloop %] > <tr> > <th><input type="checkbox" class="select_hold" data-id="[% reserveloo.reserve_id | html %]"/></th> >- <td><span data-order="[% reserveloo.waitingdate | html %]">[% reserveloo.waitingdate | $KohaDates %]</span></td> >- <td><span data-order="[% reserveloo.reservedate | html %]">[% reserveloo.reservedate | $KohaDates %]</span></td> >+ <td data-order="[% reserveloo.waitingdate | html %]"><span>[% reserveloo.waitingdate | $KohaDates %]</span></td> >+ <td data-order="[% reserveloo.reservedate | html %]"><span>[% reserveloo.reservedate | $KohaDates %]</span></td> > [% IF table_name == 'holdscr' %] > <td> > [% FOREACH cancellation_request IN reserveloo.cancellation_requests %] >@@ -35,7 +35,7 @@ > [% END %] > </td> > [% END %] >- <td><span data-order="[% reserveloo.expirationdate | html %]">[% reserveloo.expirationdate | $KohaDates %]</span></td> >+ <td data-order="[% reserveloo.expirationdate | html %]"><span>[% reserveloo.expirationdate | $KohaDates %]</span></td> > <td> > [% INCLUDE 'biblio-title.inc' biblio=reserveloo.biblio link = 1 %] > [% UNLESS ( item_level_itypes ) %] >-- >2.39.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32503
:
144884
|
144885
|
144886
|
144980
|
144981
|
144982
|
145051
|
145052
|
145053
|
147142
|
147143
|
147144