Bugzilla – Attachment 144889 Details for
Bug 31611
More visibly highlight records that cannot be batch deleted/modified
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool
Bug-31611-Clearly-highlight-biblios-that-cannot-be.patch (text/plain), 2.23 KB, created by
Alex Buckley
on 2022-12-30 00:48:01 UTC
(
hide
)
Description:
Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2022-12-30 00:48:01 UTC
Size:
2.23 KB
patch
obsolete
>From 2951c52d102389f0a081ef0d64e1fdd2f707f51d Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Fri, 23 Sep 2022 11:16:22 +1200 >Subject: [PATCH] Bug 31611: Clearly highlight biblios that cannot be deleted > in the Batch record deletion tool > >Test plan: >1. Apply patch >2. Check out an item >3. Go to: Tools > 'Batch record deletion' >4. Into the 'Enter a list of record numbers' area paste in the >biblionumber belonging to the checked-out item and that of a biblio without checked out items >5. Submit the form >6. Observe the row of the biblio with checked-out items is highlighted yellow, with a >red cross in the first column >7. Hover over the red cross to see the reason why the biblio cannot be >deleted >8. Observe the row of the biblio without checked-out items is not >highlighted yellow, and does have a checkbox in the first column >9. Click 'Delete selected records' >10. Confirm the biblio without checked-out items is successfully deleted > >Sponsored-by: Toi Ohomai Institute of Technology, New Zealand >--- > .../prog/en/modules/tools/batch_delete_records.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >index 3a0555329b..8b01818980 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >@@ -305,12 +305,12 @@ > > $("#selectall").click(); > >+ //Show a red cross if a biblio cannot be deleted > [% IF recordtype == 'biblio' %] > $(".records input:checkbox[data-issues!='0']").each(function(){ >- $(this).attr('title', MSG_CANNOT_BE_DELETED) >- $(this).prop('disabled', true); >- $(this).prop('checked', false); >- $(this).parents('tr').find('td').css('background-color', '#ffff99'); >+ $(this).parents('tr').find('td').css('background-color', '#ffff99') >+ $(this).replaceWith("<span class='error'><i class='fa fa-times fa-lg'></i></span>") >+ $(".records i").attr('title', MSG_CANNOT_BE_DELETED) > }); > [% END %] > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31611
:
140878
|
140879
|
140880
|
144888
|
144889
|
144890
|
144897
|
144898
|
147286
|
147287