Attachment 144917 Details for Bug 31095 – Bug 31095: Remove GetDebarments from Restriction/Type.t

[patch] Bug 31095: Remove GetDebarments from Restriction/Type.t

Bug-31095-Remove-GetDebarments-from-RestrictionTyp.patch (text/plain), 1.60 KB, created by Jonathan Druart on 2023-01-02 14:59:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-01-02 14:59:41 UTC

Size: 1.60 KB

patch

obsolete

>From f137afcde65f77f3b241769d62c4d60ef10c97eb Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 25 Aug 2022 09:23:36 +0100
>Subject: [PATCH] Bug 31095: Remove GetDebarments from Restriction/Type.t
>
>This patch replaces GetDebarments with $patron->restrictions in
>t/db_dependent/Koha/Patron/Restriction/Type.t
>
>Test plan
>1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to
>   the patch
>2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after
>   the patch
>3. Confirm no tests were removed
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Koha/Patron/Restriction/Type.t | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patron/Restriction/Type.t b/t/db_dependent/Koha/Patron/Restriction/Type.t
>index 850f734520a..1caae5d8735 100755
>--- a/t/db_dependent/Koha/Patron/Restriction/Type.t
>+++ b/t/db_dependent/Koha/Patron/Restriction/Type.t
>@@ -81,13 +81,10 @@ subtest 'delete() tests' => sub {
>         }
>     );
>     ok( $used_restriction_type->delete, 'Used restriction type deleted' );
>-    my $debarments = Koha::Patron::Debarments::GetDebarments(
>-        {
>-            borrowernumber => $patron->borrowernumber
>-        }
>-    );
>+    my $restrictions = $patron->restrictions;
>+    my $THE_restriction = $restrictions->next;
>     is(
>-        $debarments->[0]->{type},
>+        $THE_restriction->type->code,
>         $default_restriction_type->code,
>         'Used restriction updated to default'
>     );
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 31095: 139614 | 139719 | 139720 | 139721 | 139722 | 139723 | 139724 | 139725 | 139726 | 139727 | 139728 | 139742 | 139743 | 139744 | 139745 | 139746 | 139747 | 139748 | 139749 | 139750 | 139751 | 139752 | 139753 | 139754 | 139755 | 139756 | 139757 | 139758 | 140714 | 140715 | 140716 | 140717 | 140718 | 140719 | 140720 | 140721 | 140722 | 140723 | 140724 | 140725 | 140726 | 140727 | 140728 | 140729 | 140730 | 140731 | 142059 | 142060 | 142061 | 142062 | 142063 | 142064 | 142065 | 142066 | 142067 | 142068 | 142069 | 142070 | 142071 | 142072 | 142073 | 142074 | 142075 | 142076 | 143745 | 143746 | 143747 | 143748 | 143749 | 143750 | 143751 | 143752 | 143753 | 143754 | 143755 | 143756 | 143757 | 143758 | 143759 | 143760 | 143761 | 143762 | 143763 | 144903 | 144904 | 144905 | 144906 | 144907 | 144908 | 144909 | 144910 | 144911 | 144912 | 144913 | 144914 | 144915 | 144916 | 144917 | 144918 | 144919 | 144920 | 144921 | 145800 | 145801 | 145803 | 145845