Attachment 144955 Details for Bug 32550 – Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod

[patch] Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod

Bug-32550-bug-28445-follow-up-Fix-Clear-on-loan-li.patch (text/plain), 1.43 KB, created by Lucas Gass (lukeg) on 2023-01-03 18:30:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-01-03 18:30:41 UTC

Size: 1.43 KB

patch

obsolete

>From bdfa91c51fe40a61173645d45a6ace43d166a09e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 3 Jan 2023 13:59:07 +0100
>Subject: [PATCH] Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on
> item batch mod
>
>The 'Clear on loan' link displayed at the top of the batch item
>modification tool has been broken by bug 28445.
>
>data-is-onloan attribute is supposed to be 1 or 0, but we passed the
>checkout (Koha::Checkout=HASH)
>
>Test plan:
>1. Enter a checked-out barcode in the 'Batch item modification' page
>2. Click 'Continue'
>3. Notice a table is loaded displaying the on-loan item with a ticked checkbox 4. Click the 'Clear on loan' link above the table
>5. Notice the on-loan item is no longer selected
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> Koha/UI/Table/Builder/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/UI/Table/Builder/Items.pm b/Koha/UI/Table/Builder/Items.pm
>index 615d2108713..8837ad5e282 100644
>--- a/Koha/UI/Table/Builder/Items.pm
>+++ b/Koha/UI/Table/Builder/Items.pm
>@@ -84,7 +84,7 @@ sub build_table {
>             safe_to_delete => $item->safe_to_delete,
>             holds          => $item->biblio->holds->count,
>             item_holds     => $item->holds->count,
>-            is_checked_out => $item->checkout || 0,
>+            is_checked_out => $item->checkout ? 1 : 0,
>         };
>         push @items, $item_info;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32550: 144934 | 144955 | 145259