Bugzilla – Attachment 144982 Details for
Bug 32503
Holds awaiting pickup doesn't sort dates correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32503: Use first cancellation for date ordering
Bug-32503-Use-first-cancellation-for-date-ordering.patch (text/plain), 2.39 KB, created by
Martin Renvoize (ashimema)
on 2023-01-04 11:00:44 UTC
(
hide
)
Description:
Bug 32503: Use first cancellation for date ordering
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-01-04 11:00:44 UTC
Size:
2.39 KB
patch
obsolete
>From 89dc76a99f8d16889b5f87eabe931c32a64e69ba Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 4 Jan 2023 10:59:55 +0000 >Subject: [PATCH] Bug 32503: Use first cancellation for date ordering > >--- > .../prog/en/includes/waiting_holds.inc | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index 8440476f68e..e6caa50f4a0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -8,7 +8,7 @@ > <th>Waiting since</th> > <th>Date hold placed</th> > [% IF table_name == 'holdscr' %] >- <th data-type="@data-sort">Date cancellation requested</th> >+ <th>Date cancellation requested</th> > [% END %] > <th>Expiration date</th> > <th class="anti-the">Title</th> >@@ -29,11 +29,19 @@ > <td data-order="[% reserveloo.waitingdate | html %]"><span>[% reserveloo.waitingdate | $KohaDates %]</span></td> > <td data-order="[% reserveloo.reservedate | html %]"><span>[% reserveloo.reservedate | $KohaDates %]</span></td> > [% IF table_name == 'holdscr' %] >- <td> >- [% FOREACH cancellation_request IN reserveloo.cancellation_requests %] >- <span data-order="[% cancellation_request.creation_date | html %]">[% cancellation_request.creation_date | $KohaDates %]</span> >+ [% IF reserveloo.cancellation_requests.count %] >+ [% FOREACH cancellation_request IN reserveloo.cancellation_requests %] >+ [% IF loop.first %] >+ <td data-order="[% cancellation_request.creation_date | html %]"> >+ [% END %] >+ <span>[% cancellation_request.creation_date | $KohaDates %]</span> >+ [% IF loop.last %] >+ </td> >+ [% END %] >+ [% END %] >+ [% ELSE %] >+ <td></td> > [% END %] >- </td> > [% END %] > <td data-order="[% reserveloo.expirationdate | html %]"><span>[% reserveloo.expirationdate | $KohaDates %]</span></td> > <td> >-- >2.39.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32503
:
144884
|
144885
|
144886
|
144980
|
144981
|
144982
|
145051
|
145052
|
145053
|
147142
|
147143
|
147144