Attachment 144984 Details for Bug 32561 – Bug 32561: Prevent worker to run with unecessary modules in memory

[patch] Bug 32561: Prevent worker to run with unecessary modules in memory

Bug-32561-Prevent-worker-to-run-with-unecessary-mo.patch (text/plain), 1.24 KB, created by Kyle M Hall (khall) on 2023-01-04 11:53:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-01-04 11:53:34 UTC

Size: 1.24 KB

patch

obsolete

>From 8d315c660bfbcb9e14a87cfd31eb863a63f5687a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 4 Jan 2023 10:08:06 +0100
>Subject: [PATCH] Bug 32561: Prevent worker to run with unecessary modules in
> memory
>
>Regression of bug 28413, bug 30410 added a "use Koha::Plugins" statement at the top of Koha::BackgroundJob, and so all Koha module are loaded by the worker on startup.
>
>See bug 28413 for more info
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/BackgroundJob.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm
>index 727bc3b2f7..0ba7ba46ed 100644
>--- a/Koha/BackgroundJob.pm
>+++ b/Koha/BackgroundJob.pm
>@@ -25,7 +25,6 @@ use Try::Tiny qw( catch try );
> use C4::Context;
> use Koha::DateUtils qw( dt_from_string );
> use Koha::Exceptions;
>-use Koha::Plugins;
> use Koha::Exceptions::BackgroundJob;
> 
> use base qw( Koha::Object );
>@@ -442,6 +441,7 @@ sub plugin_types_to_classes {
>     my ($self) = @_;
> 
>     unless ( exists $self->{_plugin_mapping} ) {
>+        require Koha::Plugins;
>         my @plugins = Koha::Plugins->new()->GetPlugins( { method => 'background_tasks', } );
> 
>         foreach my $plugin (@plugins) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32561: 144973 | 144974 | 144975 | 144984 | 144985 | 144986 | 145617