Attachment 145026 Details for Bug 31935 – Bug 31935: (follow-up) Make form look better

[patch] Bug 31935: (follow-up) Make form look better

Bug-31935-follow-up-Make-form-look-better.patch (text/plain), 3.93 KB, created by Jonathan Druart on 2023-01-04 15:57:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-01-04 15:57:31 UTC

Size: 3.93 KB

patch

obsolete

>From 5de467c742078dce488bbbcc507fa162596dc4f8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 8 Dec 2022 21:13:00 +0000
>Subject: [PATCH] Bug 31935: (follow-up) Make form look better
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/serials/subscription-add.tt              | 5 +++--
> koha-tmpl/intranet-tmpl/prog/js/subscription-add.js          | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index 8c3ea64a8b5..138d7cbba7b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -14,6 +14,7 @@ fieldset.rows li.radio { width: 100%; } /* override staff-global.css */
> /* Prevents Bootstrap menus from being hidden inside modal */
> #mana_search_result .modal { overflow: visible; }
> #mana_search_result .modal-body { overflow-y: visible; }
>+.inputnote { padding-left: 13rem; padding-top: 1rem; }
> fieldset.rows table { clear: none; margin: 0; }
> </style>
> </head>
>@@ -88,12 +89,12 @@ fieldset.rows table { clear: none; margin: 0; }
>                                 [% END %]
>                                 <li>
>                                     <label for="aqbooksellerid">Vendor: </label>
>-                                    <input type="text" name="aqbooksellerid" id="aqbooksellerid" value="[% aqbooksellerid | html %]" size="8" /> (<input type="text" name="aqbooksellername" id="aqbooksellername" value="[% aqbooksellername | html %]" disabled="disabled" readonly="readonly" />) <a href="#" id="vendor_search"><i class="fa fa-search"></i> Search for a vendor</a>
>+                                    <input type="text" name="aqbooksellerid" id="aqbooksellerid" value="[% aqbooksellerid | html %]" size="8" /><input type="text" name="aqbooksellername" id="aqbooksellername" value="[% aqbooksellername | html %]" disabled="disabled" readonly="readonly" /><a href="#" id="vendor_search"><i class="fa fa-search"></i> Search for a vendor</a>
>                                 </li>
>                                 <li>
>                                     <label for="biblionumber" class="required">Record:</label>
>                                     <input type="text" name="biblionumber" id="biblionumber" value="[% bibnum | html %]" size="8" />
>-                                    (<input type="text" name="title" value="[% bibliotitle | html %]" disabled="disabled" readonly="readonly" />) <span class="required" title="Subscriptions must be associated with a bibliographic record">Required</span>
>+                                    <input type="text" name="title" value="[% bibliotitle | html %]" disabled="disabled" readonly="readonly" /><span class="required" title="Subscriptions must be associated with a bibliographic record">Required</span>
>                                     <span id="error_bib_not_exist"></span>
>                                     <div class="hint">Subscriptions must be associated with a bibliographic record</div>
>                                     <div class="inputnote"> <a href="#" id="record_search"><i class="fa fa-search"></i> Search for record</a>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>index 98755dd5a82..0b829749621 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>@@ -740,7 +740,7 @@ $(document).ready(function() {
>     });
> 
>     $("input[name='serialsadditems']").on("change", function(){
>-        const display = $(this).val() == "1" ? "block" : "none";
>+        const display = $(this).val() == "1" ? "flex" : "none";
>         $(".use_items").css('display', display).find("select").val("")
>     });
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 31935: 142581 | 142591 | 144510 | 144521 | 144522 | 145025 | 145026