Attachment 145083 Details for Bug 32491 – Bug 32491: Split patron search terms on comma

[patch] Bug 32491: Split patron search terms on comma

Bug-32491-Split-patron-search-terms-on-comma.patch (text/plain), 1.48 KB, created by Kyle M Hall (khall) on 2023-01-06 15:04:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-01-06 15:04:45 UTC

Size: 1.48 KB

patch

obsolete

>From d248aa5a459431a2a67db2ddbefab96b2c86bca5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 5 Jan 2023 09:23:45 +0100
>Subject: [PATCH] Bug 32491: Split patron search terms on comma
>
>Previous behaviour allowed search 'surname, firstname'. We should remove
>the comma from the search terms.
>
>Test plan:
>On the main patron search, search for "surname, firstname" and confirm
>that with this patch applied the search returns the expected results.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index de4ba90c0d..9b394c9320 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -314,7 +314,7 @@
>                 "-and": function(){
>                     let pattern = $("#search_patron_filter").val();
>                     if (!pattern) return "";
>-                    let patterns = pattern.split(' ').filter(function(s){ return s.length });
>+                    let patterns = pattern.split(/[\s,]+/).filter(function(s){ return s.length });
> 
>                     let filters = [];
>                     let search_type = $("#searchtype_filter").val() || "contain";
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32491: 145054 | 145058 | 145077 | 145078 | 145079 | 145083 | 145084