Bugzilla – Attachment 145086 Details for
Bug 32576
ILL needs the page-section treatment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32576: Replace panels with page-sections
Bug-32576-Replace-panels-with-page-sections.patch (text/plain), 7.58 KB, created by
Martin Renvoize (ashimema)
on 2023-01-06 15:34:39 UTC
(
hide
)
Description:
Bug 32576: Replace panels with page-sections
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-01-06 15:34:39 UTC
Size:
7.58 KB
patch
obsolete
>From 1afb5f8550871f58c76f5cd25895796414937cae Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 6 Jan 2023 15:33:29 +0000 >Subject: [PATCH] Bug 32576: Replace panels with page-sections > >--- > .../prog/en/modules/ill/ill-requests.tt | 80 +++++++++---------- > 1 file changed, 36 insertions(+), 44 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index c9d2f31f44b..1859a631b09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -604,11 +604,8 @@ > ILL request log > </a> > </div> >- <div class="ill-view-panel panel panel-default"> >- <div class="panel-heading"> >- <h3>Request details</h3> >- </div> >- <div class="panel-body"> >+ <div class="page-section"> >+ <h3>Request details</h3> > <h4>Details from library</h4> > <div class="rows"> > <ol> >@@ -689,7 +686,6 @@ > [% END %] > </ol> > </div> >- </div> > </div> > > <div id="dataPreview" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="dataPreviewLabel" aria-hidden="true"> >@@ -740,44 +736,40 @@ > </div> > </div> > >- <div class="ill-view-panel panel panel-default"> >- <div class="panel-heading"> >- <h3>[% request.illcomments.count | html %] comments</h3> >- </div> >- <div class="panel-body"> >- [% IF request.illcomments.count && request.illcomments.count > 0 %] >- [% FOREACH comment IN request.illcomments %] >- <div class="rows comment_[% comment.patron.categorycode | html %]"> >- <h5>Comment by: >- <a href="[% borrowerlink | url %]" title="View borrower details"> >- [% comment.patron.firstname _ " " _ comment.patron.surname _ " [" _ comment.patron.cardnumber _ "]" | html %]</a> >- [% comment.timestamp | $KohaDates with_hours => 1 %]</h5> >- <p>[% comment.comment | html %]</p> >- </div> >- [% END %] >- [% END %] >- <div class="rows"> >- <h3><a id="toggle_addcomment" href="#">Add comment</a></h3> >- <div id="addcomment" class="content_hidden"> >- <form class="validated" method="post" action="/cgi-bin/koha/ill/ill-requests.pl"> >- <input type="hidden" value="save_comment" name="method"> >- <input type="hidden" value="[% csrf_token | html %]" name="csrf_token"> >- <input type="hidden" value="[% request.illrequest_id | html %]" name="illrequest_id"> >- <fieldset class="rows"> >- <ol> >- <li> >- <label class="required" for="comment">Comment: </label> >- <textarea class="required" required="required" cols="80" rows="10" id="comment" name="comment"></textarea> >- <span class="required">Required</span> >- </li> >- </ol> >- </fieldset> >- <fieldset class="action"> >- <input type="submit" class="btn btn-primary" value="Submit" /> >- </fieldset> >- </form> >- </div> >+ <div class="page-section"> >+ <h3>[% request.illcomments.count | html %] comments</h3> >+ [% IF request.illcomments.count && request.illcomments.count > 0 %] >+ [% FOREACH comment IN request.illcomments %] >+ <div class="rows comment_[% comment.patron.categorycode | html %]"> >+ <h5>Comment by: >+ <a href="[% borrowerlink | url %]" title="View borrower details"> >+ [% comment.patron.firstname _ " " _ comment.patron.surname _ " [" _ comment.patron.cardnumber _ "]" | html %]</a> >+ [% comment.timestamp | $KohaDates with_hours => 1 %]</h5> >+ <p>[% comment.comment | html %]</p> > </div> >+ [% END %] >+ [% END %] >+ <div class="rows"> >+ <h3><a id="toggle_addcomment" href="#">Add comment</a></h3> >+ <div id="addcomment" class="content_hidden"> >+ <form class="validated" method="post" action="/cgi-bin/koha/ill/ill-requests.pl"> >+ <input type="hidden" value="save_comment" name="method"> >+ <input type="hidden" value="[% csrf_token | html %]" name="csrf_token"> >+ <input type="hidden" value="[% request.illrequest_id | html %]" name="illrequest_id"> >+ <fieldset class="rows"> >+ <ol> >+ <li> >+ <label class="required" for="comment">Comment: </label> >+ <textarea class="required" required="required" cols="80" rows="10" id="comment" name="comment"></textarea> >+ <span class="required">Required</span> >+ </li> >+ </ol> >+ </fieldset> >+ <fieldset class="action"> >+ <input type="submit" class="btn btn-primary" value="Submit" /> >+ </fieldset> >+ </form> >+ </div> > </div> > </div> > >@@ -791,7 +783,7 @@ > [% ELSIF query_type == 'availability' %] > <!-- availability --> > <h1>Availability</h1> >- <div id="results"> >+ <div id="results" class="page-section"> > <h3>Displaying availability results</h3> > <form method="POST" action="/cgi-bin/koha/ill/ill-requests.pl"> > [% FOREACH key IN whole.keys %] >-- >2.39.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32576
:
145085
|
145086
|
145342
|
145343
|
147430
|
147431
|
147489
|
147490