Bugzilla – Attachment 145112 Details for
Bug 31957
Translation: Ability to change the sentence structure on library administration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31957: Improve translatability of text containing links on libraries admin page
Bug-31957-Improve-translatability-of-text-containi.patch (text/plain), 5.35 KB, created by
Katrin Fischer
on 2023-01-06 22:54:36 UTC
(
hide
)
Description:
Bug 31957: Improve translatability of text containing links on libraries admin page
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-01-06 22:54:36 UTC
Size:
5.35 KB
patch
obsolete
>From 49c5f097a7d42dd8128bcbe7d3f72a24d6840de1 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 6 Jan 2023 22:33:43 +0000 >Subject: [PATCH] Bug 31957: Improve translatability of text containing links > on libraries admin page > >The libraries administration page has several links to system >preferences that appear within sentences or with other text >around it. To make translations easier, we need to make sure that >those links don't break context. > >To test: >* Activate IllModule (so we can see the ILL staff email setting) >* Go to administration > libraries >* Verify that the links for those settings show correctly > * Reply-to > * Return-Path > * Ill staff email > * MARC organization code >* Apply patch >* Verify links still work and show unchanged > >If you are familiar with the process, you can also make sure >the strings now show up on po files as expected: >https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation > >https://bugs.koha-community.org/show_bug.cgi?id=31954 >--- > .../intranet-tmpl/prog/en/modules/admin/branches.tt | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 3136955622..2f73fbd3ce 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -3,6 +3,7 @@ > [% USE Asset %] > [% SET footerjs = 1 %] > [% USE TablesSettings %] >+[% USE KohaSpan %] > [% INCLUDE 'doc-head-open.inc' %] > [% IF library %][% SET OpacLibraryInfo = library.opac_info( lang => lang ) %][% END %] > >@@ -193,7 +194,8 @@ Libraries › Administration › Koha > <input type="text" name="branchillemail" id="branchillemail" class="email" size="80" value="[% library.branchillemail | html %]" /> > <div class="hint"> > [% IF ( CAN_user_parameters_manage_sysprefs ) %] >- Default: <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLDefaultStaffEmail">ILLDefaultStaffEmail</a> system preference >+ [% SET pref_ILLDefaultStaffEmail_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILLDefaultStaffEmail">ILLDefaultStaffEmail</a>' %] >+ Default: [% pref_ILLDefaultStaffEmail_link | $raw %] system preference > [% ELSE %] > Default: ILLDefaultStaffEmail system preference > [% END %] >@@ -205,7 +207,8 @@ Libraries › Administration › Koha > <input type="text" name="branchreplyto" id="branchreplyto" class="email" size="80" value="[% library.branchreplyto | html %]" /> > <div class="hint"> > [% IF ( CAN_user_parameters_manage_sysprefs ) %] >- Default: <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ReplyToDefault">ReplyToDefault</a> system preference >+ [% SET pref_ReplyToDefault_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReplyToDefault">ReplyToDefault</a>' %] >+ Default: [% pref_ReplyToDefault_link | $raw %] system preference > [% ELSE %] > Default: ReplyToDefault system preference > [% END %] >@@ -216,7 +219,8 @@ Libraries › Administration › Koha > <input type="text" name="branchreturnpath" id="branchreturnpath" class="email" size="80" value="[% library.branchreturnpath | html %]" /> > <div class="hint"> > [% IF ( CAN_user_parameters_manage_sysprefs ) %] >- Default: <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ReturnpathDefault">ReturnpathDefault</a> system preference >+ [% SET pref_ReturnpathDefault_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReturnpathDefault">ReturnpathDefault</a>' %] >+ Default: [% pref_ReturnpathDefault_link | $raw %] system preference > [% ELSE %] > Default: ReturnpathDefault system preference > [% END %] >@@ -257,7 +261,8 @@ Libraries › Administration › Koha > <input type="text" name="marcorgcode" id="marcorgcode" size="16" maxlength="16" value="[% library.marcorgcode | html %]" /> > <div class="hint"> > [% IF ( CAN_user_parameters_manage_sysprefs ) %] >- If not filled in defaults to system preference <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=MARCOrgCode">MARCOrgCode</a>. >+ [% SET pref_MARCOrgCode_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=MARCOrgCode">MARCOrgCode</a>' %] >+ If not filled in defaults to system preference [% pref_MARCOrgCode_link | $raw %]. > [% ELSE %] > If not filled in defaults to system preference MARCOrgCode. > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31957
:
145112
|
145113
|
145161
|
145162
|
145163
|
145164
|
145165
|
146513
|
146514
|
146688