Bugzilla – Attachment 145115 Details for
Bug 32585
Followup on Bug 32583 - fix some variable references
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32585 - followup on Bug 32583 - fix some variable references
0001-Bug-32585-followup-on-Bug-32583-fix-some-variable-re.patch (text/plain), 1.41 KB, created by
Michael Hafen
on 2023-01-06 23:13:19 UTC
(
hide
)
Description:
Bug 32585 - followup on Bug 32583 - fix some variable references
Filename:
MIME Type:
Creator:
Michael Hafen
Created:
2023-01-06 23:13:19 UTC
Size:
1.41 KB
patch
obsolete
>From 6090ae6152f10b1124f079a6ec672818defb6505 Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Fri, 6 Jan 2023 16:11:01 -0700 >Subject: [PATCH] Bug 32585 - followup on Bug 32583 - fix some variable > references >Content-Type: text/plain; charset="utf-8" > >Bug 32583 change the $item variable from a hash to an object. Trivial patch >to change some hash references to object method calls. >--- > catalogue/moredetail.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 90f2de0b07..5a2ff15173 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -166,12 +166,12 @@ foreach my $item (@items){ > > # item has a host number if its biblio number does not match the current bib > if ($item->biblionumber ne $biblionumber){ >- $item_info->{hostbiblionumber} = $item->{biblionumber}; >+ $item_info->{hostbiblionumber} = $item->biblionumber; > $item_info->{hosttitle} = $item->biblio->title; > } > > # FIXME The acquisition code below could be improved using methods from Koha:: objects >- my $order = GetOrderFromItemnumber( $item->{'itemnumber'} ); >+ my $order = GetOrderFromItemnumber( $item->itemnumber ); > $item_info->{'basketno'} = $order->{'basketno'}; > $item_info->{'orderdate'} = $order->{'entrydate'}; > if ($item_info->{'basketno'}){ >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32585
:
145115
|
145228
|
147236