Bugzilla – Attachment 145169 Details for
Bug 32239
Report options for adding groups/sub groups are misaligned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32239: Remove uneeded CSS from reports.css
Bug-32239-Remove-uneeded-CSS-from-reportscss.patch (text/plain), 2.41 KB, created by
David Nind
on 2023-01-09 23:23:15 UTC
(
hide
)
Description:
Bug 32239: Remove uneeded CSS from reports.css
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-01-09 23:23:15 UTC
Size:
2.41 KB
patch
obsolete
>From 253477f4640a7480bfeb8b63e2efa1119cb5fdc5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 9 Jan 2023 18:32:39 +0000 >Subject: [PATCH] Bug 32239: Remove uneeded CSS from reports.css > >To test: >1. Apply patch. >2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly. >3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/css/reports.css | 5 ----- > .../prog/en/modules/reports/guided_reports_start.tt | 4 ++-- > 2 files changed, 2 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/reports.css b/koha-tmpl/intranet-tmpl/prog/css/reports.css >index 86e79a764c..80cc39da51 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/reports.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/reports.css >@@ -69,11 +69,6 @@ del { > color: #C00; > } > >-fieldset.rows label, >-fieldset.rows span.label { >- width: 12em; >-} >- > fieldset.rows .column_config_row { > display: flex; > flex-wrap: wrap; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index f5f2f7f7b3..0d4dd73384 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -2352,7 +2352,7 @@ > <label>Report group:</label> > <input type="radio" name="select_or_create_group" > id="select_group" checked="checked" /> >- <label for="select_group" style="float:none">Select</label> >+ <label for="select_group">Select</label> > <select name="group" id="group_select"> > <option value="">(None)</option> > [% FOREACH group IN groups_with_subgroups %] >@@ -2366,7 +2366,7 @@ > [% END %] > </select> > <input type="radio" name="select_or_create_group" id="create_group" /> >- <label for="create_group" style="float:none">or create:</label> >+ <label for="create_group">or create:</label> > <input type="text" name="group" id="group_input" title="Group code" placeholder="Code" /> > <input type="text" name="groupdesc" id="groupdesc_input" title="Group name" placeholder="Name" /> > </li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32239
:
145158
|
145169
|
145823