Attachment 145170 Details for Bug 32602 – Bug 32602: SIP server doesn't respect IssuingInProcess system preference

[patch] Bug 32602: SIP server doesn't respect IssuingInProcess system preference

Bug-32602-SIP-server-doesnt-respect-IssuingInProce.patch (text/plain), 1.70 KB, created by Alex Buckley on 2023-01-10 04:29:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2023-01-10 04:29:36 UTC

Size: 1.70 KB

patch

obsolete

>From 7dfb3b05315115c6243e256fd96264db2fca9688 Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Tue, 10 Jan 2023 16:55:10 +1300
>Subject: [PATCH] Bug 32602: SIP server doesn't respect IssuingInProcess system
> preference
>
>The system preference 'IssuingInProcess' when set to "Don't prevent" means patrons will still be allowed to issue items if their rental charge took the patron over the noissuescharge system preference.
>
>However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess' equals "Don't prevent") when they try to issue items that take them over the noissuecharge amount.
>
>Test plan:
>1. Configure the BK item type to have a rental charge of $2
>2. Configure system preferences:
>- noissuescharge = $5
>- IssuingInProcess = Don't prevent
>3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd item you
>cannot issue the third item
>
>4. Apply patches
>5. Restart your SIP2 server
>6. From a SIP2 device issue 3 BK items to a different patron and notice you can issue all
>three items
>
>Sponsored-by: Horowhenua District Council, New Zealand
>---
> C4/SIP/ILS.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
>index ff9ee74067..b7ecc7f150 100644
>--- a/C4/SIP/ILS.pm
>+++ b/C4/SIP/ILS.pm
>@@ -139,7 +139,9 @@ sub checkout {
>         } elsif ($patron->expired) {
>             $circ->screen_msg("Patron expired");
>         } elsif ($patron->fine_blocked) {
>-            $circ->screen_msg("Patron has fines");
>+            if ( !C4::Context->preference("IssuingInProcess") ) {
>+	        $circ->screen_msg("Patron has fines");
>+	    }
>         } else {
>             $circ->screen_msg("Patron blocked");
>         }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32602: 145170 | 145249 | 149152 | 149153 | 156808 | 156809 | 157296 | 157297