Attachment 145188 Details for Bug 32013 – Bug 32013: (QA follow-up) Move mock to avoid warns from sample data creation

[patch] Bug 32013: (QA follow-up) Move mock to avoid warns from sample data creation

Bug-32013-QA-follow-up-Move-mock-to-avoid-warns-fr.patch (text/plain), 1.80 KB, created by Martin Renvoize (ashimema) on 2023-01-10 14:12:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-01-10 14:12:36 UTC

Size: 1.80 KB

patch

obsolete

>From 1438cd0126f95ab24c07996ef41e1f2a22802cec Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 9 Jan 2023 14:57:44 +0000
>Subject: [PATCH] Bug 32013: (QA follow-up) Move mock to avoid warns from
> sample data creation
>
>Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/Koha/SearchEngine/Indexer.t | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t
>index 726ac6c902f..82589fe4dc4 100755
>--- a/t/db_dependent/Koha/SearchEngine/Indexer.t
>+++ b/t/db_dependent/Koha/SearchEngine/Indexer.t
>@@ -261,12 +261,6 @@ subtest 'Test AddRenewal indexer call' => sub {
>         t::lib::Mocks::mock_preference( 'SearchEngine', $engine );
>         my $mock_index = Test::MockModule->new("Koha::SearchEngine::".$engine."::Indexer");
> 
>-        $mock_index->mock( index_records => sub {
>-            warn $engine;
>-            my ($package, undef, undef) = caller;
>-            warn $package;
>-        });
>-
>         my $biblio = $builder->build_sample_biblio();
>         my $patron  = $builder->build_object( { class => 'Koha::Patrons' } );
>         my $item = $builder->build_sample_item({
>@@ -282,6 +276,13 @@ subtest 'Test AddRenewal indexer call' => sub {
>             }
>         });
> 
>+        $mock_index->mock( index_records => sub {
>+            warn $engine;
>+            my ($package, undef, undef) = caller;
>+            warn $package;
>+        });
>+
>+
>         warnings_are{
>             AddRenewal($patron->borrowernumber, $item->itemnumber, $item->homebranch, undef, undef, undef, 0);
>         } [$engine,"Koha::Item"], "index_records is called for $engine when adding a renewal (AddRenewal())";
>-- 
>2.39.0

Actions: View | Diff | Splinter Review

Attachments on bug 32013: 144442 | 144464 | 145150 | 145151 | 145152 | 145186 | 145187 | 145188 | 149276 | 149277 | 149278 | 149279