Attachment 145205 Details for Bug 32495 – Bug 32495: Mis-matched required fields in UI and api

[patch] Bug 32495: Mis-matched required fields in UI and api

Bug-32495-Mis-matched-required-fields-in-UI-and-ap.patch (text/plain), 1.63 KB, created by David Nind on 2023-01-10 22:17:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-01-10 22:17:29 UTC

Size: 1.63 KB

patch

obsolete

>From 2eb4585b80261d8df768e3dbe7c61851cb7ec942 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 9 Jan 2023 15:12:18 +0000
>Subject: [PATCH] Bug 32495: Mis-matched required fields in UI and api
>
>The "description" field is marked as required in the UI when creating a new Agreement. This flag has been removed to match the API where it is not a required field. Is Perpetual has not been marked as required as it is a checkbox with a default selection so will always provide a value.
>
>Test plan:
>1) In the ERM module, add a new agreement and observe that the Description field is required
>2) Apply patch
>3) Repeat step 1 but this time the Required flag will not be visible.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/js/vue/components/ERM/AgreementsFormAdd.vue           | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>index b21340f562..260c50f9e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>@@ -48,9 +48,6 @@
>                                     cols="50"
>                                     required
>                                 />
>-                                <span class="required">{{
>-                                    $__("Required")
>-                                }}</span>
>                             </li>
>                             <li>
>                                 <label for="agreement_status"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32495: 145149 | 145205 | 147290 | 147555 | 147558