Attachment 145238 Details for Bug 24616 – Bug 24616: Do not save form if user press cancel

[patch] Bug 24616: Do not save form if user press cancel

Bug-24616-Do-not-save-form-if-user-press-cancel.patch (text/plain), 1.63 KB, created by ByWater Sandboxes on 2023-01-12 16:49:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2023-01-12 16:49:32 UTC

Size: 1.63 KB

patch

obsolete

>From 188f7103ba4144ad322c96caa63ab2d3158509d2 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Tue, 1 Nov 2022 09:21:57 +0200
>Subject: [PATCH] Bug 24616: Do not save form if user press cancel
>
>If one starts to copy a notice but then cancels
>this when pop-up is displayed, changes are still
>saved. This patch fixes this.
>
>To test:
>1. Copy notice to a library where it already exists
>2. Press save and then cancel when pop-up is
>displayed
>=> Form and changes are still saved
>3. Apply this patch.
>4. Repeat steps 1. and 2.
>=> Form is no longer saved
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: ml-inlibro <marie-luce.laflamme@inlibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/letter.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/letter.js b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>index da044f5dd4..365878e7f2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/letter.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>@@ -29,7 +29,7 @@ function checkCodes( new_lettercode, new_branchcode ){
>         }
>     });
> }
>-
>+//This has bug
> function confirmOverwrite( new_lettercode, new_branchcode ){
>     var letter_exists;
>     $.ajax({
>@@ -127,7 +127,7 @@ $(document).ready(function() {
>                     var new_lettercode = $("#code").val();
>                     var new_branchcode = $("#branch").val();
>                     var confirm = confirmOverwrite( new_lettercode, new_branchcode );
>-                    if( confirm && confirm === false){
>+                    if(confirm === false){
>                         return false;
>                     }
>                 }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 24616: 138242 | 138503 | 142672 | 142850 | 142856 | 145238 | 146148 | 146149 | 146150