Bugzilla – Attachment 145259 Details for
Bug 32550
'Clear on loan' link on Batch item modification doesn't untick on loan items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod
Bug-32550-bug-28445-follow-up-Fix-Clear-on-loan-li.patch (text/plain), 1.53 KB, created by
Marcel de Rooy
on 2023-01-13 10:45:05 UTC
(
hide
)
Description:
Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-01-13 10:45:05 UTC
Size:
1.53 KB
patch
obsolete
>From 4c1aa8c1df526bfe2f0ac7ca8e4f363fc829d269 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 3 Jan 2023 13:59:07 +0100 >Subject: [PATCH] Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on > item batch mod >Content-Type: text/plain; charset=utf-8 > >The 'Clear on loan' link displayed at the top of the batch item >modification tool has been broken by bug 28445. > >data-is-onloan attribute is supposed to be 1 or 0, but we passed the >checkout (Koha::Checkout=HASH) > >Test plan: >1. Enter a checked-out barcode in the 'Batch item modification' page >2. Click 'Continue' >3. Notice a table is loaded displaying the on-loan item with a ticked checkbox 4. Click the 'Clear on loan' link above the table >5. Notice the on-loan item is no longer selected > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/UI/Table/Builder/Items.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/UI/Table/Builder/Items.pm b/Koha/UI/Table/Builder/Items.pm >index 615d210871..8837ad5e28 100644 >--- a/Koha/UI/Table/Builder/Items.pm >+++ b/Koha/UI/Table/Builder/Items.pm >@@ -84,7 +84,7 @@ sub build_table { > safe_to_delete => $item->safe_to_delete, > holds => $item->biblio->holds->count, > item_holds => $item->holds->count, >- is_checked_out => $item->checkout || 0, >+ is_checked_out => $item->checkout ? 1 : 0, > }; > push @items, $item_info; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32550
:
144934
|
144955
| 145259