Attachment 145280 Details for Bug 30979 – Bug 30979: Add 'OpacTrustedCheckout' preference

[patch] Bug 30979: Add 'OpacTrustedCheckout' preference

Bug-30979-Add-OpacTrustedCheckout-preference.patch (text/plain), 3.45 KB, created by Martin Renvoize (ashimema) on 2023-01-13 15:53:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-01-13 15:53:54 UTC

Size: 3.45 KB

patch

obsolete

>From a6299e6b61d7b55cc0120fec4ba355b2640d1ece Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 18 Jul 2022 10:22:06 +0100
>Subject: [PATCH] Bug 30979: Add 'OpacTrustedCheckout' preference
>
>This patch adds a new 'OpacTrustedCheckout' system preference to govern
>whether the library allows opac users to check out items to themselves
>from their OPAC login.
>---
> installer/data/mysql/atomicupdate/bug_30979.pl   | 16 ++++++++++++++++
> installer/data/mysql/mandatory/sysprefs.sql      |  1 +
> .../prog/en/modules/admin/preferences/opac.pref  |  8 +++++++-
> 3 files changed, 24 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_30979.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_30979.pl b/installer/data/mysql/atomicupdate/bug_30979.pl
>new file mode 100644
>index 00000000000..cb5b6ce0fbe
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_30979.pl
>@@ -0,0 +1,16 @@
>+use Modern::Perl;
>+
>+return {
>+    bug_number  => "30979",
>+    description => "Add OPACTrustedCheckout system preference",
>+    up          => sub {
>+        my ($args) = @_;
>+        my ( $dbh, $out ) = @$args{qw(dbh out)};
>+        $dbh->do(
>+            q{
>+                INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
>+	            ('OpacTrustedCheckout', '0', NULL, 'Allow logged in OPAC users to check out to themselves', 'YesNo')
>+	        }
>+        );
>+    },
>+};
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index beebd27a6fd..e747890d019 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -515,6 +515,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OpacSuppressionRedirect','1','Redirect the opac detail page for suppressed records to an explanatory page (otherwise redirect to 404 error page)','','YesNo'),
> ('opacthemes','bootstrap','','Define the current theme for the OPAC interface.','Themes'),
> ('OpacTopissue','0',NULL,'If ON, enables the \'most popular items\' link on OPAC. Warning, this is an EXPERIMENTAL feature, turning ON may overload your server','YesNo'),
>+('OpacTrustedCheckout', '0', NULL, 'Allow logged in OPAC users to check out to themselves', 'YesNo'),
> ('OPACURLOpenInNewWindow','0',NULL,'If ON, URLs in the OPAC open in a new window','YesNo'),
> ('OPACUserCSS','',NULL,'Add CSS to be included in the OPAC in an embedded <style> tag.','free'),
> ('OPACUserJS','','70|10','Define custom javascript for inclusion in OPAC','Textarea'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 043c5276d80..40c01a52d3b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -629,7 +629,13 @@ OPAC:
>                 1: "Block"
>                 0: "Don't block"
>             - expired patrons from OPAC actions such as placing a hold or renewing. Note that the setting for a patron category takes priority over this system preference.
>-
>+        -
>+            - pref: OpacTrustedCheckout
>+              default: 0
>+              choices:
>+                  0: "Don't allow"
>+                  1: Allow
>+            - "OPAC users to checkout to themselves."
>     Privacy:
>         -
>             - pref: opacreadinghistory
>-- 
>2.39.0

Actions: View | Diff | Splinter Review

Attachments on bug 30979: 139131 | 139132 | 139133 | 139134 | 141274 | 141275 | 141276 | 141277 | 141278 | 141279 | 141300 | 145264 | 145265 | 145266 | 145267 | 145268 | 145277 | 145280 | 145281 | 145282 | 145283 | 145284 | 145285 | 145620 | 145621 | 145622 | 145623 | 145624 | 145625 | 145626 | 145627 | 145628 | 145629 | 145630 | 150867 | 150868 | 150869 | 150870 | 150871 | 150872 | 150873 | 150874 | 150875 | 150876 | 150877 | 150878 | 150879 | 150880 | 150881 | 150882 | 150883 | 150884 | 150885 | 150886 | 150887 | 150888 | 150889 | 150967 | 150968 | 150969 | 150970 | 150971 | 150972 | 150973 | 150974 | 151254 | 151255 | 151256 | 151257 | 151258 | 151259 | 151260 | 151261 | 151358 | 151359 | 151360 | 151361 | 151362 | 151363 | 151364 | 151365 | 151368 | 151369 | 151370 | 151371 | 151372 | 151373 | 151374 | 151375 | 151376 | 152789 | 152790 | 152791 | 152792 | 152793 | 152794 | 152795 | 152796 | 152797 | 153459 | 153460 | 153461 | 153462 | 153463 | 153464 | 153465 | 153466 | 153467 | 153500 | 153501 | 153502 | 153503