Attachment 145296 Details for Bug 32019 – Bug 32019: (follow-up) Fix terminology and styling

[patch] Bug 32019: (follow-up) Fix terminology and styling

Bug-32019-follow-up-Fix-terminology-and-styling.patch (text/plain), 3.09 KB, created by Kyle M Hall (khall) on 2023-01-13 17:27:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-01-13 17:27:49 UTC

Size: 3.09 KB

patch

obsolete

>From 86d2b4e525330acdd8848abc78e96aedc2aee641 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 31 Oct 2022 10:42:57 +0000
>Subject: [PATCH] Bug 32019: (follow-up) Fix terminology and styling
>
>This patch adds periods to description on batch mod form and alters
>language to follow proper terminology
>
>Styling is fixed to align forms
>
>Blank option is removed, No made default
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Items.pm                                              | 3 ++-
> .../intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt   | 7 +++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Items.pm b/Koha/Items.pm
>index 7a6bfdfb2b..3f3ba3fb4f 100644
>--- a/Koha/Items.pm
>+++ b/Koha/Items.pm
>@@ -229,7 +229,8 @@ Set the passed boolean value to items.exclude_from_local_holds_priority
> 
> =item mark_items_returned
> 
>-Move issues on these items to the old issues table, do not mark items found or adjust statuses or fines
>+Move issues on these items to the old issues table, do not mark items found, or
>+adjust damaged/withdrawn statuses, or fines, or locations.
> 
> =item callback
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index 6fb72079c3..26be2b1c84 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -199,13 +199,12 @@
>                             <legend>Options</legend>
>                             <ol>
>                                 <li>
>+                                    <div class="hint">This option checks in items to remove them from patron accounts.</br>Items are not marked found, nor do damaged/withdrawn statuses prevent this return, nor are item locations updated. This feature is intended to allow removal of checkouts from patron accounts without affecting fines or other statuses.</div></br>
>                                     <div class="subfield_line">
>-                                        <p>This option allows returning items to remove them from patron accounts</br>Items are not marked found nor do statuses prevent this return. This feature is intended to allow removal and deletion of items without affecting fines or other statuses</p></br>
>-                                        <label for="mark_items_returned">Mark items returned:</label>
>+                                        <label for="mark_items_returned">Check in items:</label>
>                                         <select id="mark_items_returned" name="mark_items_returned" class="input_marceditor select2" style="width: 50px">
>-                                            <option selected></option>
>                                             <option value="1">Yes</option>
>-                                            <option value="0">No</option>
>+                                            <option value="0" selected>No</option>
>                                         </select>
>                                     </div>
>                                 </li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32019: 142719 | 142720 | 142764 | 142765 | 142766 | 142823 | 142824 | 142825 | 145294 | 145295 | 145296