Attachment 145381 Details for Bug 32663 – Bug 32663: Limit streetnumber to 10 characters in OPAC

[patch] Bug 32663: Limit streetnumber to 10 characters in OPAC

Bug-32663-Limit-streetnumber-to-10-characters-in-O.patch (text/plain), 2.15 KB, created by David Nind on 2023-01-18 04:17:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-01-18 04:17:33 UTC

Size: 2.15 KB

patch

obsolete

>From de4ddfcbf5ff6d80b84fd17e18bc0d768e959c15 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 18 Jan 2023 01:28:38 +0000
>Subject: [PATCH] Bug 32663: Limit streetnumber to 10 characters in OPAC
>
>This change harmonizes the patron streetnumber input between
>the staff interface and the OPAC, so that you can only enter 10
>characters into the streetnumber for the OPAC. Without this change,
>a fatal error will be thrown trying to save the too long data.
>
>Test plan:
>0. Apply the patch
>1. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
>2. Note that you can only enter 10 characters into the "Street number"
>field as a self-registration patron
>3. Log into Koha
>4. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
>5. Note that you can only enter 10 characters into the "Street number"
>field when editing logged in patron details too
>6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S
>7. Note that you can only enter 10 characters into the "Street number"
>field as a staff member
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 04c8c3e655..b051a14c02 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -15,7 +15,7 @@
>         <li>
>             <label for="borrower_streetnumber" class="[% required.streetnumber | html %]">Street number:</label>
> 
>-            <input type="text" id="borrower_streetnumber" name="borrower_streetnumber" value="[% borrower.streetnumber | html %]" class="[% required.streetnumber | html %]" />
>+            <input type="text" id="borrower_streetnumber" name="borrower_streetnumber" value="[% borrower.streetnumber | html %]" class="[% required.streetnumber | html %]" size="5" maxlength="10" />
>             <div class="required_label [% required.streetnumber | html %]">Required</div>
>         </li>
>     [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32663: 145379 | 145381 | 145879 | 147421