Attachment 145391 Details for Bug 32665 – Bug 32665: Fix typo in template condition

[patch] Bug 32665: Fix typo in template condition

Bug-32665-Fix-typo-in-template-condition.patch (text/plain), 3.09 KB, created by Owen Leonard on 2023-01-18 12:23:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-01-18 12:23:01 UTC

Size: 3.09 KB

patch

obsolete

>From 68ef1684ff596efee51034d3c0e746879f97ab3c Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 18 Jan 2023 04:38:36 +0000
>Subject: [PATCH] Bug 32665: Fix typo in template condition
>
>This patch fixes a typo in a template condition so that
>the about.pl warning about RequireChoosingExistingAuthority is
>shown when it's the only warning to display
>
>Test plan:
>0. Don't apply the patch yet
>1. Go to http://localhost:8081/cgi-bin/koha/about.pl
>2. Note that "No warnings" is shown
>3. Apply the patch
>4. Go to http://localhost:8081/cgi-bin/koha/about.pl
>5. Note that there is a heading for "Warnings regarding the
>system configuration" and a specific warning about the
>"RequireChoosingExistingAuthority" system preference
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 5b7834a434..145bd102a7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -219,7 +219,7 @@
>         </div>
> 
>         <div role="tabpanel" class="tab-pane" id="sysinfo">
>-    [% IF warnRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing %]
>+    [% IF warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing %]
>         [% IF (warnIsRootUser) %]
>             <h2>Warning regarding current user</h2>
>             <p>You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32665: 145382 | 145391 | 147279 | 147399