Attachment 145392 Details for Bug 32634 – Bug 32634: (follow-up) Restructure page headings

[patch] Bug 32634: (follow-up) Restructure page headings

Bug-32634-follow-up-Restructure-page-headings.patch (text/plain), 2.22 KB, created by Owen Leonard on 2023-01-18 13:14:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-01-18 13:14:52 UTC

Size: 2.22 KB

patch

obsolete

>From 742d0d7d66991fc6850b2c5ed8b60f2a77ebb35e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 18 Jan 2023 13:12:08 +0000
>Subject: [PATCH] Bug 32634: (follow-up) Restructure page headings
>
>An error in template logic is preventing the page's h1 from displaying.
>Rather than fixing this I have changed the h1 to display a generic
>"Transaction details" h1. The h2 shows the transaction type (credit or
>debit).
>
>The h2 is now inside the .page-section.
>---
> .../en/modules/members/accountline-details.tt | 23 ++++++++-----------
> 1 file changed, 9 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>index ac3969dd60..067b868dbe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>@@ -63,25 +63,20 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>-            <h1>
>-                [% IF type == 'credit' %]
>-                    <span>Details of payment</span>
>-                [% ELSIF type == 'debit' %]
>-                    <span>Details of fee</span>
>-                [% END %]
>-            </h1>
>-
>             [% INCLUDE 'members-toolbar.inc' borrowernumber=patron.borrowernumber %]
> 
>+            <h1>Transaction details</h1>
>+
>             [% IF accountline %]
>-                [% af_values = accountline.additional_field_values %]
>-                [% IF accountline.credit_type_code %]
>-                    <h2>Details of credit</h2>
>-                [% ELSIF accountline.debit_type_code %]
>-                    <h2>Details of debit</h2>
>-                [% END %]
> 
>                 <div class="page-section">
>+                    [% af_values = accountline.additional_field_values %]
>+                    [% IF accountline.credit_type_code %]
>+                        <h2>Details of credit</h2>
>+                    [% ELSIF accountline.debit_type_code %]
>+                        <h2>Details of debit</h2>
>+                    [% END %]
>+
>                     <table id="table_account_fines">
>                         <thead>
>                             <tr>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32634: 145322 | 145357 | 145392 | 148904 | 148905 | 149352 | 149353