Attachment 145516 Details for Bug 32376 – Bug 32376: Remove creation of selenium_failure_2.png

[patch] Bug 32376: Remove creation of selenium_failure_2.png

Bug-32376-Remove-creation-of-seleniumfailure2png.patch (text/plain), 1.27 KB, created by Kyle M Hall (khall) on 2023-01-20 14:25:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-01-20 14:25:02 UTC

Size: 1.27 KB

patch

obsolete

>From 5a8a6324b3397162996e026c7dd47d8656b7a225 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 30 Nov 2022 08:32:20 +0100
>Subject: [PATCH] Bug 32376: Remove creation of selenium_failure_2.png
>
>This was for debugging purpose.
>
>Test plan:
>Run the tests and confirm that the screenshot is not generated when the
>patch is applied
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/selenium/authentication_2fa.t | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/t/db_dependent/selenium/authentication_2fa.t b/t/db_dependent/selenium/authentication_2fa.t
>index 8c9979be5d..053b47343d 100755
>--- a/t/db_dependent/selenium/authentication_2fa.t
>+++ b/t/db_dependent/selenium/authentication_2fa.t
>@@ -94,7 +94,6 @@ SKIP: {
>         $driver->find_element('//*[@id="register-2FA"]')->click;
>         # Wait for the response then go to the page, don't wait for the redirect
>         $s->wait_for_ajax;
>-        $driver->capture_screenshot('selenium_failure_2.png');
>         $driver->get($s->base_url . q|members/two_factor_auth.pl|);
>         is(
>             $driver->find_element( '//div[@id="registration-status-disabled"]/div[@class="two-factor-status"]' )->get_text,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32376: 144338 | 144417 | 145516