Attachment 145541 Details for Bug 32662 – Bug 32662: Use template wrapper for item circulation alerts page

[patch] Bug 32662: Use template wrapper for item circulation alerts page

Bug-32662-Use-template-wrapper-for-item-circulatio.patch (text/plain), 3.35 KB, created by Owen Leonard on 2023-01-20 16:41:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-01-20 16:41:43 UTC

Size: 3.35 KB

patch

obsolete

>From c2c14d6536d494ae7ca026614fa1504247b1c1ca Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 20 Jan 2023 16:39:32 +0000
>Subject: [PATCH] Bug 32662: Use template wrapper for item circulation alerts
> page
>
>This patch implements the template WRAPPER system (see Bug 32571)
>for building tabs on the item circulation alerts page.
>
>To test, apply the patch and go to Administration -> Item
>circulation alerts. There should be two tabs, "Checkout" and
>"Check-in" which work correctly.
>---
> .../modules/admin/item_circulation_alerts.tt  | 29 +++++++++----------
> 1 file changed, 13 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>index e067c194f2..f97c98c41e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>@@ -113,16 +113,14 @@
>                 <h2>Circulation alerts for [% Branches.GetName( branch ) || 'Default' | html %]</h2>
>                 <p>Click on the grid to toggle the settings.</p>
> 
>-
>-                <div id="alerttabs" class="toptabs">
>-
>-                    <ul class="nav nav-tabs" role="tablist">
>-                        <li role="presentation" class="active"><a href="#checkout" aria-controls="checkout" role="tab" data-toggle="tab">Checkout</a></li>
>-                        <li role="presentation"><a href="#checkin" aria-controls="checkin" role="tab" data-toggle="tab">Check-in</a></li>
>-                    </ul>
>-
>-                    <div class="tab-content">
>-                        <div role="tabpanel" class="tab-pane active" id="checkout">
>+                [% WRAPPER tabs id= "alerttabs" %]
>+                    [% WRAPPER tabs_nav %]
>+                        [% WRAPPER tab_item tabname= "checkout" bt_active= 1 %] Checkout [% END %]
>+                        [% WRAPPER tab_item tabname= "checkin" %] Check-in [% END %]
>+                    [% END %]
>+
>+                    [% WRAPPER tab_panels %]
>+                        [% WRAPPER tab_panel tabname="checkout" bt_active= 1 %]
>                             <h3>Checkout</h3>
>                             <table class="grid active" width="100%">
>                                 <thead>
>@@ -144,9 +142,9 @@
>                                     [% END %]
>                                 </tbody>
>                             </table> 
>-                        </div> 
>+                        [% END #/ #checkout %]
> 
>-                        <div role="tabpanel" class="tab-pane" id="checkin">
>+                        [% WRAPPER tab_panel tabname="checkin" %]
>                             <h3>Check-in</h3>
>                             <table class="grid active" width="100%">
>                                 <thead>
>@@ -168,11 +166,10 @@
>                                     [% END %]
>                                 </tbody>
>                             </table>
>-                        </div>
>-                    </div> 
>-
>-                </div> 
>+                        [% END # /#checkin %]
>+                    [% END # /.tab_panels %]
> 
>+                [% END # //#alerttabs %]
> 
>             </main>
>         </div> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32662: 145373 | 145541 | 145789 | 146203