Attachment 145547 Details for Bug 32689 – Bug 32689: Add missing space between 773$i label text and content

[patch] Bug 32689: Add missing space between 773$i label text and content

Bug-32689-Add-missing-space-between-773i-label-tex.patch (text/plain), 3.30 KB, created by David Nind on 2023-01-20 17:52:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-01-20 17:52:33 UTC

Size: 3.30 KB

patch

obsolete

>From 2d481cd641667e4b3c74a80b0cc3a7a4690c1557 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Date: Fri, 20 Jan 2023 15:49:09 +0000
>Subject: [PATCH] Bug 32689: Add missing space between 773$i label text and
> content
>
>When 777 Ind. 2 = 8, $i will be used as the label. In this case,
>we were missing a space between the $i and the other subfields.
>This patch makes sure there is a space.
>
>Note: the colon is expected to be part of the data here.
>
>To test:
>* Update default framework to display 773 a t w i by default in the editor,
>  OPAC and staff interface.
>* Search for a record in the staff interface
>* Click New > Add child record from the detail page
>* Enter 245 and any mandatory fields
>* Add $i to 773 entry and make the indicators: 0 8
>* On the detail page and the result lists,
>  $i will be used a label, but there'll be no space between
>  label and content.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 9 +++++----
> .../opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl      | 9 +++++----
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>index 33ae687ad6..d9a49ffcf5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>@@ -626,10 +626,11 @@
>                         <xsl:when test="@ind2=' '">
>                             In:
>                         </xsl:when>
>-                        <xsl:when test="@ind2=8">
>-                            <xsl:if test="marc:subfield[@code='i']">
>-                                <xsl:value-of select="marc:subfield[@code='i']"/>
>-                            </xsl:if>
>+                        <xsl:when test="@ind2=8 and marc:subfield[@code='i']">
>+                            <xsl:call-template name="subfieldSelect">
>+                                <xsl:with-param name="codes">i</xsl:with-param>
>+                            </xsl:call-template>
>+                            <xsl:text> </xsl:text>
>                         </xsl:when>
>                     </xsl:choose>
>                     </span>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>index 64b49ed816..e899b81099 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>@@ -589,10 +589,11 @@
>                         <xsl:when test="@ind2=' '">
>                             In:
>                         </xsl:when>
>-                        <xsl:when test="@ind2=8">
>-                            <xsl:if test="marc:subfield[@code='i']">
>-                                <xsl:value-of select="marc:subfield[@code='i']"/>
>-                            </xsl:if>
>+                        <xsl:when test="@ind2=8 and marc:subfield[@code='i']">
>+                            <xsl:call-template name="subfieldSelect">
>+                                <xsl:with-param name="codes">i</xsl:with-param>
>+                            </xsl:call-template>
>+                            <xsl:text> </xsl:text>
>                         </xsl:when>
>                     </xsl:choose>
>                     </span>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32689: 145532 | 145547 | 145867