Attachment 145550 Details for Bug 30254 – Bug 30254: Unit tests

[patch] Bug 30254: Unit tests

Bug-30254-Unit-tests.patch (text/plain), 1.34 KB, created by Kyle M Hall (khall) on 2023-01-20 18:25:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-01-20 18:25:33 UTC

Size: 1.34 KB

patch

obsolete

>From 7b83577e362b564c8067359ea5e0c40659fd670f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 31 Oct 2022 18:37:18 +0000
>Subject: [PATCH] Bug 30254: Unit tests
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Koha/Item.t | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t
>index 04d7465e79..e23c7dab3d 100755
>--- a/t/db_dependent/Koha/Item.t
>+++ b/t/db_dependent/Koha/Item.t
>@@ -1471,7 +1471,7 @@ subtest 'store() tests' => sub {
> 
>     subtest '_set_found_trigger() tests' => sub {
> 
>-        plan tests => 8;
>+        plan tests => 9;
> 
>         $schema->storage->txn_begin;
> 
>@@ -1541,6 +1541,14 @@ subtest 'store() tests' => sub {
>             'type is correct'
>         );
> 
>+        # Let's build a new item
>+        $item   = $builder->build_sample_item({ itemlost => 1, itemlost_on => dt_from_string() });
>+        $item->set( { itemlost => 0 } )->store;
>+
>+        $messages = $item->object_messages;
>+        warn Data::Dumper::Dumper( $messages );
>+        is( scalar @{$messages}, 0, 'This item has no history, no associated lost fines, presumed not lost by patron, no messages returned');
>+
>         $schema->storage->txn_rollback;
>     };
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30254: 142839 | 142840 | 142851 | 142852 | 142853 | 145549 | 145550 | 145551 | 145552 | 147185