Bugzilla – Attachment 145594 Details for
Bug 32573
background_jobs_worker.pl should ACK a message before it forks and runs the job
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32573: Send ACK message to RabbitMQ before handling the job
Bug-32573-Send-ACK-message-to-RabbitMQ-before-hand.patch (text/plain), 1.31 KB, created by
Jonathan Druart
on 2023-01-24 08:13:37 UTC
(
hide
)
Description:
Bug 32573: Send ACK message to RabbitMQ before handling the job
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-01-24 08:13:37 UTC
Size:
1.31 KB
patch
obsolete
>From f42544197760d89871be5463b17b993e104a14d4 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Jan 2023 11:35:42 -0500 >Subject: [PATCH] Bug 32573: Send ACK message to RabbitMQ before handling the > job > >Splitting off this functionality from bug 32558. This is the comment that started this discussion: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558#c15 > >From the O'Reilly book Mobile and Web Messaging: > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > misc/background_jobs_worker.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/background_jobs_worker.pl b/misc/background_jobs_worker.pl >index a9eda516813..9f2d0d659b9 100755 >--- a/misc/background_jobs_worker.pl >+++ b/misc/background_jobs_worker.pl >@@ -100,8 +100,8 @@ while (1) { > # It could work in a first step, but then we will want to handle job that will be created from the message received > my $job = Koha::BackgroundJobs->find($args->{job_id}); > >+ $conn->ack( { frame => $frame } ); # Acknowledge the message was recieved > process_job( $job, $args ); >- $conn->ack( { frame => $frame } ); # FIXME depending on success? > > } else { > my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32573
:
145066
|
145594
|
145595
|
145608
|
145612