Bugzilla – Attachment 145696 Details for
Bug 31244
Logout when not logged in raise a 500
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31244: [21.11.x] Fix 500 if logout and not logged in
Bug-31244-2111x-Fix-500-if-logout-and-not-logged-i.patch (text/plain), 1.56 KB, created by
Martin Renvoize (ashimema)
on 2023-01-26 17:45:17 UTC
(
hide
)
Description:
Bug 31244: [21.11.x] Fix 500 if logout and not logged in
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-01-26 17:45:17 UTC
Size:
1.56 KB
patch
obsolete
>From ad6cd5a0ed5005407f682fe38e2f97ef1ae8f465 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 26 Jul 2022 14:55:02 +0200 >Subject: [PATCH] Bug 31244: [21.11.x] Fix 500 if logout and not logged in > >Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 > C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 > C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 > >Test plan: >Open a private window >Hit /cgi-bin/koha/mainpage.pl?logout.x=1 > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Rebased for 21.11.x >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index e8e75b84ce3..bb00ded4a90 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -912,7 +912,7 @@ sub checkauth { > > # voluntary logout the user > # check wether the user was using their shibboleth session or a local one >- my $shibSuccess = C4::Context->userenv->{'shibboleth'}; >+ my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef; > $session->delete(); > $session->flush; > $cookie = $cookie_mgr->clear_unless( $query->cookie, @$cookie ); >-- >2.39.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31244
:
138147
|
138148
|
138188
|
145696
|
145717