Bugzilla – Attachment 145776 Details for
Bug 32738
Correct upload local cover image title tag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32738: Correct upload local cover image title tag
Bug-32738-Correct-upload-local-cover-image-title-t.patch (text/plain), 3.12 KB, created by
David Nind
on 2023-01-27 20:39:41 UTC
(
hide
)
Description:
Bug 32738: Correct upload local cover image title tag
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-01-27 20:39:41 UTC
Size:
3.12 KB
patch
obsolete
>From a4ce1a8dfb8e2500d22ba2e284edbcb6ec07d41e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 27 Jan 2023 15:05:30 +0000 >Subject: [PATCH] Bug 32738: Correct upload local cover image title tag >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch corrects the local cover image template's title tag so that >it conforms to the changes made in Bug 26703, 'Modify the "title" >elements to contain unique information first.' > >The patch also makes minor corrections to the page's breadcrumbs. > >To test you must have the LocalCoverImages system preference enabled. > >- Apply the patch and go to Cataloging -> Upload local cover image. >- The page title should be correct: > Upload local cover image ⺠Cataloging ⺠Koha >- The breadcrumbs should be: > Home -> Cataloging -> Upload cover image >- Locate a bibliographic record and view its details. >- Click the "Images" tab, then the "Upload" button. >- The page title should now be > Upload local cover image for [title] ⺠Cataloging ⺠Koha >- The breadcrumbs should now be: > Home -> Cataloging -> Upload local cover image -> Upload cover for > [title] > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/tools/upload-images.tt | 23 +++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >index e2cd7749c9..0faecc1c4b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >@@ -3,12 +3,13 @@ > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] > <title> >- Koha › >- Cataloging › >- Upload local cover image > [% IF ( biblio ) %] >- › [% INCLUDE 'biblio-title-head.inc' %] >+ Upload local cover image for [% INCLUDE 'biblio-title-head.inc' %] › >+ [% ELSE %] >+ Upload local cover image › > [% END %] >+ Cataloging › >+ Koha > </title> > [% INCLUDE 'doc-head-close.inc' %] > [% FILTER collapse %] >@@ -89,9 +90,11 @@ > <li> > <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> > </li> >- <li> >- <a href="/cgi-bin/koha/tools/upload-cover-image.pl">Upload local cover image</a> >- </li> >+ [% IF uploadimage || biblio || itemnumber || biblionumber %] >+ <li> >+ <a href="/cgi-bin/koha/tools/upload-cover-image.pl">Upload local cover image</a> >+ </li> >+ [% END %] > > [% IF ( uploadimage ) %] > <li> >@@ -104,6 +107,12 @@ > <a href="#" aria-current="page"><em>[% INCLUDE 'biblio-title.inc' %]</em></a> > </li> > [% END %] >+ [% ELSIF biblio %] >+ <li> >+ <a href="#" aria-current="page"> >+ Upload cover for <em>[% INCLUDE 'biblio-title.inc' %]</em> >+ </a> >+ </li> > [% ELSIF itemnumber %] > <li> > <a href="#" aria-current="page"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32738
:
145769
|
145776
|
145830