Attachment 145799 Details for Bug 29021 – Bug 29021: (QA follow-up) Remove useless warnings

[patch] Bug 29021: (QA follow-up) Remove useless warnings

Bug-29021-QA-follow-up-Remove-useless-warnings.patch (text/plain), 1.43 KB, created by Tomás Cohen Arazi (tcohen) on 2023-01-30 15:05:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-01-30 15:05:07 UTC

Size: 1.43 KB

patch

obsolete

>From bcaf68b51fe73dfe0b38896c0f241725edbcb01b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 30 Jan 2023 12:01:41 -0300
>Subject: [PATCH] Bug 29021: (QA follow-up) Remove useless warnings
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/Account/Line.t | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Account/Line.t b/t/db_dependent/Koha/Account/Line.t
>index c7c7b342132..b5926b4f70d 100755
>--- a/t/db_dependent/Koha/Account/Line.t
>+++ b/t/db_dependent/Koha/Account/Line.t
>@@ -504,9 +504,9 @@ subtest 'Renewal related tests' => sub {
>     $schema->storage->txn_begin;
> 
>     my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
>-    my $staff = $builder->build_object( { class => 'Koha::Patrons' } );
>-    my $item = $builder->build_object({ class => 'Koha::Items' });
>-    my $issue = $builder->build_object(
>+    my $staff  = $builder->build_object( { class => 'Koha::Patrons' } );
>+    my $item   = $builder->build_sample_item;
>+    my $issue  = $builder->build_object(
>         {
>             class => 'Koha::Checkouts',
>             value => {
>@@ -525,6 +525,7 @@ subtest 'Renewal related tests' => sub {
>         debit_type_code   => "OVERDUE",
>         status            => "UNRETURNED",
>         amountoutstanding => 0,
>+        amount            => 0,
>         interface         => 'commandline',
>     })->store;
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 29021: 134897 | 144503 | 145761 | 145762 | 145799