Attachment 145803 Details for Bug 31095 – Bug 31095: (Rebase follow-up) Correct fine rules and AddIssue calls

[patch] Bug 31095: (Rebase follow-up) Correct fine rules and AddIssue calls

Bug-31095-Rebase-follow-up-Correct-fine-rules-and-.patch (text/plain), 2.15 KB, created by Martin Renvoize (ashimema) on 2023-01-30 17:29:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-01-30 17:29:56 UTC

Size: 2.15 KB

patch

obsolete

>From 2d55e2cc5a3f23dcda1395c8ded340caf69c657c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 30 Jan 2023 17:27:53 +0000
>Subject: [PATCH] Bug 31095: (Rebase follow-up) Correct fine rules and AddIssue
> calls
>
>This patch corrects the errant call to AddIssue that passes a patron
>object instread of a patron hash to AddIssue in the tests and also adds
>lengthunit to squash a pair of warnings.
>
>However, it doesn't resolve the failing test.. still somthing going on
>there.
>---
> t/db_dependent/Circulation.t | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 84389d60069..d57c63d8958 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2856,9 +2856,10 @@ subtest 'AddReturn + suspension_chargeperiod' => sub {
>             categorycode => undef,
>             itemtype     => undef,
>             branchcode   => undef,
>-            rules        => {
>-                finedays => 0,
>-            }
>+            rules => {
>+                finedays   => 0,
>+                lengthunit => 'days',
>+              }
>         }
>     );
> 
>@@ -2870,7 +2871,7 @@ subtest 'AddReturn + suspension_chargeperiod' => sub {
>         }
>     );
> 
>-    AddIssue( $patron, $item_1->barcode, $now->clone->subtract( days => 1 ) );
>+    AddIssue( $patron->unblessed, $item_1->barcode, $now->clone->subtract( days => 1 ) );
>     my ( undef, $message ) = AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
>     is( $message->{WasReturned} && exists $message->{ForeverDebarred}, 1, 'Forever debarred message for Addreturn when overdue');
> 
>@@ -2888,7 +2889,7 @@ subtest 'AddReturn + suspension_chargeperiod' => sub {
>         }
>     );
> 
>-    AddIssue( $patron, $item_1->barcode, $now->clone->subtract( days => 1 ) );
>+    AddIssue( $patron->unblessed, $item_1->barcode, $now->clone->subtract( days => 1 ) );
>     (undef, $message) = AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
>     is( $message->{WasReturned} && exists $message->{PrevDebarred}, 1, 'Previously debarred message for Addreturn when overdue');
> };
>-- 
>2.39.1

Actions: View | Diff | Splinter Review

Attachments on bug 31095: 139614 | 139719 | 139720 | 139721 | 139722 | 139723 | 139724 | 139725 | 139726 | 139727 | 139728 | 139742 | 139743 | 139744 | 139745 | 139746 | 139747 | 139748 | 139749 | 139750 | 139751 | 139752 | 139753 | 139754 | 139755 | 139756 | 139757 | 139758 | 140714 | 140715 | 140716 | 140717 | 140718 | 140719 | 140720 | 140721 | 140722 | 140723 | 140724 | 140725 | 140726 | 140727 | 140728 | 140729 | 140730 | 140731 | 142059 | 142060 | 142061 | 142062 | 142063 | 142064 | 142065 | 142066 | 142067 | 142068 | 142069 | 142070 | 142071 | 142072 | 142073 | 142074 | 142075 | 142076 | 143745 | 143746 | 143747 | 143748 | 143749 | 143750 | 143751 | 143752 | 143753 | 143754 | 143755 | 143756 | 143757 | 143758 | 143759 | 143760 | 143761 | 143762 | 143763 | 144903 | 144904 | 144905 | 144906 | 144907 | 144908 | 144909 | 144910 | 144911 | 144912 | 144913 | 144914 | 144915 | 144916 | 144917 | 144918 | 144919 | 144920 | 144921 | 145800 | 145801 | 145803 | 145845