Attachment 145847 Details for Bug 32712 – Bug 32712: (QA follow-up) Use Koha.Preference

[patch] Bug 32712: (QA follow-up) Use Koha.Preference

Bug-32712-QA-follow-up-Use-KohaPreference.patch (text/plain), 2.13 KB, created by Tomás Cohen Arazi (tcohen) on 2023-01-31 12:35:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-01-31 12:35:04 UTC

Size: 2.13 KB

patch

obsolete

>From 320d184bb1e1f0fb66fec45fb035d7049fd6e808 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 31 Jan 2023 09:34:13 -0300
>Subject: [PATCH] Bug 32712: (QA follow-up) Use Koha.Preference
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc | 4 ++--
> opac/opac-detail.pl | 4 ----
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>index 305282861c9..4d3d4df21d2 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>@@ -49,13 +49,13 @@
> 
> [% SET itemavailable = 0 %]
> [% IF onsite_checkout %]
>- [% IF ( OPACShowCheckoutName ) %]
>+ [% IF ( Koha.Preference('OPACShowCheckoutName') ) %]
> Currently in local use by [% checkout_patron.firstname | html %] [% checkout_patron.surname | html %] [% IF ( checkout_patron.cardnumber ) %]([% checkout_patron.cardnumber | html %])[% END %]
> [% ELSE %]
> Currently in local use
> [% END %]
> [% ELSE %]
>- [% IF ( OPACShowCheckoutName ) %]
>+ [% IF ( Koha.Preference('OPACShowCheckoutName') ) %]
> Checked out to [% checkout_patron.firstname | html %] [% checkout_patron.surname | html %] [% IF ( checkout_patron.cardnumber ) %]([% checkout_patron.cardnumber | html %])[% END %]
> [% ELSE %]
> Checked out
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 961be881435..98c4f94a8cb 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -488,10 +488,6 @@ if ($session->param('busc')) {
> }
> }
> 
>-$template->param(
>- OPACShowCheckoutName => C4::Context->preference("OPACShowCheckoutName"),
>-);
>-
> $items = Koha::Items->search_ordered(
> [
> 'me.biblionumber' => $biblionumber,
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32712: 145808 | 145831 | 145832 | 145840 | 145841 | 145847 | 146014