Attachment 145859 Details for Bug 32587 – Bug 32587: Add page-section to 'items with no checkouts' report

[patch] Bug 32587: Add page-section to 'items with no checkouts' report

Bug-32587-Add-page-section-to-items-with-no-checko.patch (text/plain), 9.36 KB, created by Martin Renvoize (ashimema) on 2023-01-31 13:05:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-01-31 13:05:49 UTC

Size: 9.36 KB

patch

obsolete

>From 32bdd6c84b686852ad973130b6772db0c9d23839 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 7 Jan 2023 01:31:34 +0000
>Subject: [PATCH] Bug 32587: Add page-section to 'items with no checkouts'
> report
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This adds page sections to the summary and result tables
>for the 'items with no checkouts' report.
>
>To test:
>* Run the 'item with no checkouts' report with different settings
>* Confirm result tables are missing the white brackground from
>  page-section
>* Apply patch
>* Confirm the result tables now do have the white background
>
>Signed-off-by: FrÃ©dÃ©ric Demians <f.demians@tamil.fr>
>  â Confirm both problem and solution
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/reports/catalogue_out.tt  | 112 +++++++++---------
> 1 file changed, 58 insertions(+), 54 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>index 12e29249bb6..35a62dd0dd8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>@@ -53,67 +53,71 @@
>                         [% END %]
> 
>                         [% IF ( mainloo.looptables ) %]
>-                            <h3><a name="summary" id="summary"></a>Summary</h3>
>-                            <table id="summary_table">
>-                                <tr>
>-                                    <th>Group</th>
>-                                    <th>Call number range</th>
>-                                    <th>Number of items displayed</th>
>-                                    <th>Total items in group</th>
>-                                </tr>
>-                                [% FOREACH looptable IN mainloo.looptables %]
>+                            <div class="page-section">
>+                                <h3><a name="summary" id="summary"></a>Summary</h3>
>+                                <table id="summary_table">
>                                     <tr>
>-                                        <td>
>-                                            <a href="#table[% looptable.coltitle | uri %]">[% looptable.coltitle | html %]</a>
>-                                        </td>
>-                                        <td>
>-                                            [% IF ( looptable.looptable_count ) %]
>-                                                [% looptable.looptable_first | html %] to [% looptable.looptable_last | html %]
>-                                            [% END %]
>-                                        </td>
>-                                        <td>[% looptable.looptable_count | html %]</td>
>-                                        <td>[% looptable.coltitle_count | html %]</td>
>+                                        <th>Group</th>
>+                                        <th>Call number range</th>
>+                                        <th>Number of items displayed</th>
>+                                        <th>Total items in group</th>
>                                     </tr>
>-                                [% END %]
>-                                <tr>
>-                                    <th>TOTAL</th>
>-                                    <th></th>
>-                                    <th>[% mainloo.total_looptable_count | html %]</th>
>-                                    <th>[% mainloo.total_coltitle_count | html %]</th>
>-                                </tr>
>-                            </table>
>-                        [% END %]
>-
>-                        [% FOREACH looptable IN mainloo.looptables %]
>-                            <h3>
>-                                <a id="table[% looptable.coltitle | html %]"></a>
>-                                [% looptable.coltitle | html %]
>-                            </h3>
>-                            <table>
>-                                <tr>
>-                                    <th>#</th>
>-                                    <th>Call number</th>
>-                                    <th>Barcode</th>
>-                                    <th>Item details</th>
>-                                </tr>
>-                                [% IF ( looptable.looprow ) %]
>-                                    [% FOREACH loopro IN looptable.looprow %]
>+                                    [% FOREACH looptable IN mainloo.looptables %]
>                                         <tr>
>-                                            <td>[% loop.count | html %]</td>
>-                                            <td>[% IF ( loopro.itemcallnumber ) %][% loopro.itemcallnumber | html %][% ELSE %]No call number[% END %]</td>
>-                                            <td>[% IF ( loopro.barcode ) %][% loopro.barcode | html %][% ELSE %]No barcode[% END %]</td>
>                                             <td>
>-                                                <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loopro.biblionumber | uri %]">[% IF ( loopro.title ) %][% loopro.title | html %][% ELSE %]NO TITLE[% END %]</a> [% IF ( loopro.author ) %] by [% loopro.author | html %][% END %]</p>
>-                                                [% IF ( loopro.branch ) %]at [% Branches.GetName( loopro.branch ) | html %][% END %]
>+                                                <a href="#table[% looptable.coltitle | uri %]">[% looptable.coltitle | html %]</a>
>                                             </td>
>+                                            <td>
>+                                                [% IF ( looptable.looptable_count ) %]
>+                                                    [% looptable.looptable_first | html %] to [% looptable.looptable_last | html %]
>+                                                [% END %]
>+                                            </td>
>+                                            <td>[% looptable.looptable_count | html %]</td>
>+                                            <td>[% looptable.coltitle_count | html %]</td>
>                                         </tr>
>                                     [% END %]
>-                                    [% ELSE %]
>-                                        <tr>
>-                                            <td colspan="4">No items for [% looptable.coltitle | html %]</td>
>-                                        </tr>
>-                                    [% END %]
>-                            </table>
>+                                    <tr>
>+                                        <th>TOTAL</th>
>+                                        <th></th>
>+                                        <th>[% mainloo.total_looptable_count | html %]</th>
>+                                        <th>[% mainloo.total_coltitle_count | html %]</th>
>+                                    </tr>
>+                                </table>
>+                            </div>
>+                        [% END %]
>+
>+                        [% FOREACH looptable IN mainloo.looptables %]
>+                            <div class="page-section">
>+                                <h3>
>+                                    <a id="table[% looptable.coltitle | html %]"></a>
>+                                    [% looptable.coltitle | html %]
>+                                </h3>
>+                                <table>
>+                                    <tr>
>+                                        <th>#</th>
>+                                        <th>Call number</th>
>+                                        <th>Barcode</th>
>+                                        <th>Item details</th>
>+                                    </tr>
>+                                    [% IF ( looptable.looprow ) %]
>+                                        [% FOREACH loopro IN looptable.looprow %]
>+                                            <tr>
>+                                                <td>[% loop.count | html %]</td>
>+                                                <td>[% IF ( loopro.itemcallnumber ) %][% loopro.itemcallnumber | html %][% ELSE %]No call number[% END %]</td>
>+                                                <td>[% IF ( loopro.barcode ) %][% loopro.barcode | html %][% ELSE %]No barcode[% END %]</td>
>+                                                <td>
>+                                                    <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loopro.biblionumber | uri %]">[% IF ( loopro.title ) %][% loopro.title | html %][% ELSE %]NO TITLE[% END %]</a> [% IF ( loopro.author ) %] by [% loopro.author | html %][% END %]</p>
>+                                                    [% IF ( loopro.branch ) %]at [% Branches.GetName( loopro.branch ) | html %][% END %]
>+                                                </td>
>+                                            </tr>
>+                                        [% END %]
>+                                        [% ELSE %]
>+                                            <tr>
>+                                                <td colspan="4">No items for [% looptable.coltitle | html %]</td>
>+                                            </tr>
>+                                        [% END %]
>+                                </table>
>+                            </div>
>                         [% END %]
>                     [% END %]
>                 [% ELSE %]
>-- 
>2.39.1

Actions: View | Diff | Splinter Review

Attachments on bug 32587: 145122 | 145126 | 145859