Bugzilla – Attachment 145921 Details for
Bug 32770
Patron search field groups no longer exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32770: Restore patron search on all emails and phone numbers
Bug-32770-Restore-patron-search-on-all-emails-and-.patch (text/plain), 3.04 KB, created by
Jonathan Druart
on 2023-02-01 08:35:25 UTC
(
hide
)
Description:
Bug 32770: Restore patron search on all emails and phone numbers
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-02-01 08:35:25 UTC
Size:
3.04 KB
patch
obsolete
>From 5f155622642bcf82bf2fc03bfeb8380aa3836ada Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 1 Feb 2023 09:31:20 +0100 >Subject: [PATCH] Bug 32770: Restore patron search on all emails and phone > numbers > >Prior to bug 30063 we had "Email" and "Phone" in the search field list >that allowed a search on all email or phone attributes. > >This patch restores that (in an a bit ugly way, but cannot do easier). > >Test plan: >Confirm that "Email" and "Phone" are displayed in the search field list >when searching for patrons. Note that "Phone" was there already, but was >only searching on the first "phone" attribute. >Confirm that the search works as expected. > >Note for QA: I was not expecting the REST API to handle search on >attributes with the DB column names, I think this is a bug. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index b4589b12019..a7a4e38bd2f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -61,7 +61,7 @@ > <label for="searchfieldstype_filter">Search field:</label> > <select name="searchfieldstype" id="searchfieldstype_filter"> > [% SET standard = Koha.Preference('DefaultPatronSearchFields') || 'firstname,middle_name,surname,othernames,cardnumber,userid' %] >- [% default_fields = [ standard, 'surname', 'cardnumber', 'email', 'borrowernumber', 'userid', 'phone', 'address', 'dateofbirth', 'sort1', 'sort2' ] %] >+ [% default_fields = [ standard, 'surname', 'cardnumber', 'email,secondary_email,altaddress_email', 'borrowernumber', 'userid', 'phone,phonepro,B_phone,altcontactphone,mobile', 'address', 'dateofbirth', 'sort1', 'sort2' ] %] > [% search_options = default_fields.merge(standard.split(',')).unique %] > [% FOREACH s_o IN search_options %] > [% display_name = PROCESS patron_fields name=s_o %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >index 821b7d0b7f5..e20b906c595 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >@@ -72,6 +72,8 @@ > [%- CASE 'updated_on' -%]<span>Last updated</span> > [%- CASE 'lastseen' -%]<span>Last seen</span> > [%- CASE 'checkprevcheckout' -%]<span>Check previous checkout</span> >+ [%- CASE 'email,secondary_email,altaddress_email' -%]<span>Email</span> >+ [%- CASE 'phone,phonepro,B_phone,altcontactphone,mobile' -%]<span>Phone</span> > [%- CASE DEFAULT -%] > [%- END -%] > [%- END -%] >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32770
:
145921
|
145928
|
145935
|
146331
|
146711
|
147147
|
147696