Attachment 145924 Details for Bug 32406 – Bug 32406: Switch acq datatable from headers to query param

[patch] Bug 32406: Switch acq datatable from headers to query param

Bug-32406-Switch-acq-datatable-from-headers-to-que.patch (text/plain), 1.96 KB, created by Jonathan Druart on 2023-02-01 10:09:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-02-01 10:09:59 UTC

Size: 1.96 KB

patch

obsolete

>From 79ee81f0a1cebe958c718c2a72feed04053a4426 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 5 Dec 2022 22:50:23 +0000
>Subject: [PATCH] Bug 32406: Switch acq datatable from headers to query param
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch changes the pending orders datatable from using the
>x-koha-query header to the "q" query parameter, so that it is
>able to support UTF-8 encoded scripts rather than just Latin-1
>scripts.
>
>Test plan:
>
>1. Apply patch
>2. Go to
>http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29
>3. Change title from "Gairm" to "äº" (alternatively use "cÅur" or Arabic title)
>4. Create a basket containing multiple records including bib 29 äº
>5. Close the basket
>6. Receive shipment
>7. You should be on a page like the following:
>http://localhost:8081/cgi-bin/koha/acqui/parcel.pl?invoiceid=3
>8. In the search box, type in äº
>9. Note that you see a "Processing..." box and then the
>results are filtered to just show the order for äº
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>tcohen amend: removed the line instead as we are probably phasing out
>that DT configuration option anyway.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index 7ccc942be81..ebda2f0014e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -383,7 +383,6 @@
>                 "ajax": {
>                     "url": '/api/v1/acquisitions/orders?only_active=1'
>                 },
>-                "header_filter": true,
>                 "embed": [
>                     "basket.basket_group",
>                     "biblio.active_orders+count",
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32406: 144432 | 144446 | 145924